Skip to content

Bump CI version #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arielfoever wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

Bump CI version #1416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/sail-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
cmake-version:
description: "CMake version to install"
required: false
default: "4.1.2"
default: "4.2.0"
sail-version:
description: 'Sail version to install (use "latest" to build from source)'
required: false
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-22.04, ubuntu-24.04-arm, macos-latest]
cmake_version: ["3.20.0", "4.1.2"]
os: [ubuntu-22.04, ubuntu-24.04, ubuntu-24.04-arm, macos-latest]
Copy link
Collaborator

@jordancarlin jordancarlin Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is much benefit to running CI on both Ubuntu 22.04 and Ubuntu 24.04 other than maybe different compiler versions?

Copy link
Contributor Author

@Arielfoever Arielfoever Dec 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc and some lib like gmp

Copy link
Collaborator

@Timmmm Timmmm Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, but we do already have ubuntu-24.04-arm. I think it's ok to test the combinations with a pairwise testing approach rather than exhaustively. Doesn't cost us any more I guess but think of the environment! :-D

If we run into an issue that this would have caught we can reevaluate.

cmake_version: ["3.31.9", "4.2.0"]
Copy link
Collaborator

@jordancarlin jordancarlin Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our CMakeLists.txt files declare a minimum CMake version of 3.20, so that version should be maintained for testing.

Copy link
Contributor Author

@Arielfoever Arielfoever Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just considering if we should bump cmake min version too

Copy link
Collaborator

@jordancarlin jordancarlin Dec 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we have a strong reason to bump the minimum CMake version (a new feature we want to use that isn't supported, etc.), we should avoid increasing the minimum version. All that would do is remove support for the system CMake packaged in older distros without any benefit.

include:
- os: ubuntu-22.04
cmake_version: "4.1.2"
- os: ubuntu-24.04
cmake_version: "4.2.0"
run_all_steps: true

steps:
Expand Down
Loading