Skip to content

Big endianness Support added #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
db63dac
Big endianness support added
MuhammadHammad001 Feb 19, 2025
b7a06e3
Add conditions on sbe, ube
MuhammadHammad001 Feb 19, 2025
3930145
add ube field in sstatus
MuhammadHammad001 Feb 20, 2025
89d2664
Rename big endianness check function
MuhammadHammad001 Feb 21, 2025
758d9d0
Merge branch 'riscv:master' into big_endian
MuhammadHammad001 Mar 10, 2025
cd944ee
restructure the endianness check function
MuhammadHammad001 Mar 10, 2025
1caf3bc
update readme to add big endianness support
MuhammadHammad001 Mar 10, 2025
e14c7d0
Remove Redundant comment
MuhammadHammad001 Mar 10, 2025
bc344ee
Merge branch 'master' into big_endian
MuhammadHammad001 Mar 17, 2025
c39162f
Resolve conflicts for spie field
MuhammadHammad001 Mar 18, 2025
48a6636
Merge branch 'master' into big_endian
MuhammadHammad001 Apr 2, 2025
daa2d01
add big endianness support in mmio
MuhammadHammad001 Apr 3, 2025
552b0e3
correct logic for endianness conversion
MuhammadHammad001 Apr 3, 2025
6c2ab4d
Merge branch 'master' into big_endian
MuhammadHammad001 Apr 3, 2025
cce02b1
Merge branch 'master' into big_endian
MuhammadHammad001 Apr 4, 2025
446bce4
Add endianness test
MuhammadHammad001 Apr 5, 2025
56dff58
Refactor code
MuhammadHammad001 Apr 9, 2025
91e7d86
Merge branch 'master' into big_endian
MuhammadHammad001 Apr 9, 2025
1ecd7c7
replace is_big_endian with get_endianness
MuhammadHammad001 Apr 9, 2025
05b7087
Merge branch 'master' into big_endian
MuhammadHammad001 Apr 15, 2025
5ff2c37
Merge branch 'master' into big_endian
MuhammadHammad001 May 12, 2025
f243b51
Update Execute() to InstructionFetch()
MuhammadHammad001 May 12, 2025
6c0ae67
test to remove mtime endianness
MuhammadHammad001 May 12, 2025
8444a81
Merge branch 'master' into big_endian
MuhammadHammad001 May 12, 2025
71d4c1d
Add parameter for big endianness in config file
MuhammadHammad001 May 12, 2025
456524b
Update big endianness to true
MuhammadHammad001 May 12, 2025
cfba783
Merge branch 'master' into big_endian
MuhammadHammad001 May 13, 2025
d528507
move get_endianness to vmem_write
MuhammadHammad001 May 13, 2025
89f3768
add big endianness parameter in memory section of default config
MuhammadHammad001 May 13, 2025
33752f0
Merge branch 'master' into big_endian
MuhammadHammad001 May 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions model/prelude.sail
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,6 @@ type max_mem_access : Int = 4096

// Type used for memory access widths. Zero byte accesses are not allowed.
type mem_access_width = range(1, max_mem_access)

// Function to reverse endianness.
val reverse_endianness = pure {c: " reverse_endianness"} : forall 'n . (bits('n * 8)) -> bits('n * 8)
29 changes: 24 additions & 5 deletions model/riscv_mem.sail
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ function write_kind_of_flags (aq : bool, rl : bool, con : bool) -> write_kind =
(true, false, true) => throw(Error_not_implemented("sc.aq"))
}

val check_endianess: (AccessType(ext_access_type)) -> bool
function check_endianess(typ) = {
match effectivePrivilege(typ, mstatus, cur_privilege) {
Machine => bits_to_bool(mstatus[MBE]),
Supervisor => bits_to_bool(mstatus[SBE]),
User => bits_to_bool(mstatus[UBE]),
}
}

// only used for actual memory regions, to avoid MMIO effects
function phys_mem_read forall 'n, 0 < 'n <= max_mem_access . (t : AccessType(ext_access_type), paddr : physaddr, width : int('n), aq : bool, rl: bool, res : bool, meta : bool) -> MemoryOpResult((bits(8 * 'n), mem_meta)) = {
let result = (match read_kind_of_flags(aq, rl, res) {
Expand All @@ -73,9 +82,15 @@ function phys_mem_read forall 'n, 0 < 'n <= max_mem_access . (t : AccessType(ext
(Execute(), None()) => Err(E_Fetch_Access_Fault()),
(Read(Data), None()) => Err(E_Load_Access_Fault()),
(_, None()) => Err(E_SAMO_Access_Fault()),
(_, Some(v, m)) => { if get_config_print_mem()
then print_mem("mem[" ^ to_str(t) ^ "," ^ BitStr(physaddr_bits(paddr)) ^ "] -> " ^ BitStr(v));
Ok(v, m) }
(_, Some(v, m)) => {
let temp_var: bits('n * 8) = match (t, check_endianess(t)) {
(Execute(), _) => (v),
(_, true) => reverse_endianness(v),
(_, false) => (v),
};
if get_config_print_mem()
then print_mem("mem[" ^ to_str(t) ^ "," ^ BitStr(physaddr_bits(paddr)) ^ "] -> " ^ BitStr(temp_var));
Ok(temp_var, m) }
}
}

Expand Down Expand Up @@ -196,9 +211,13 @@ $endif

// only used for actual memory regions, to avoid MMIO effects
function phys_mem_write forall 'n, 0 < 'n <= max_mem_access . (wk : write_kind, paddr : physaddr, width : int('n), data : bits(8 * 'n), meta : mem_meta) -> MemoryOpResult(bool) = {
let result = write_ram(wk, paddr, width, data, meta);
let temp_var: bits('n * 8) = match (check_endianess(Write())) {
false => data,
true => reverse_endianness(data),
};
let result = write_ram(wk, paddr, width, temp_var, meta);
if get_config_print_mem()
then print_mem("mem[" ^ BitStr(physaddr_bits(paddr)) ^ "] <- " ^ BitStr(data));
then print_mem("mem[" ^ BitStr(physaddr_bits(paddr)) ^ "] <- " ^ BitStr(temp_var));
Ok(result)
}

Expand Down
3 changes: 3 additions & 0 deletions model/riscv_sys_control.sail
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ function reset_sys() -> unit = {
mstatus[MIE] = 0b0;
mstatus[MPRV] = 0b0;

// If little-endian memory accesses are supported, the mstatus/mstatush field MBE is reset to 0.
mstatus[MBE] = 0b0;

// "If little-endian memory accesses are supported, the mstatus/mstatush field
// MBE is reset to 0."
// TODO: The handling of mstatush is a bit awkward currently, but the model
Expand Down
7 changes: 5 additions & 2 deletions model/riscv_sys_regs.sail
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ bitfield Mstatus : bits(64) = {
SPP : 8,

MPIE : 7,
UBE : 6,
SPIE : 5,

MIE : 3,
Expand Down Expand Up @@ -244,8 +245,8 @@ function legalize_mstatus(o : Mstatus, v : bits(64)) -> Mstatus = {
// MPV = v[MPV],
// GVA = v[GVA],
/* We don't currently support changing MBE and SBE. */
// MBE = v[MBE],
// SBE = v[SBE],
MBE = v[MBE],
SBE = if extensionEnabled(Ext_S) then v[SBE] else 0b0,
/* We don't support dynamic changes to SXL and UXL. */
// SXL = if xlen == 64 then v[SXL] else o[SXL],
// UXL = if xlen == 64 then v[UXL] else o[UXL],
Expand All @@ -269,6 +270,7 @@ function legalize_mstatus(o : Mstatus, v : bits(64)) -> Mstatus = {
SPP = if extensionEnabled(Ext_S) then v[SPP] else 0b0,
VS = v[VS],
MPIE = v[MPIE],
UBE = if extensionEnabled(Ext_U) then v[UBE] else 0b0,
SPIE = v[SPIE],
MIE = v[MIE],
SIE = v[SIE],
Expand All @@ -294,6 +296,7 @@ register mstatus : Mstatus = {
}

mapping clause csr_name_map = 0x300 <-> "mstatus"
mapping clause csr_name_map = 0x310 <-> "mstatush"

function clause is_CSR_defined(0x300) = true // mstatus
function clause is_CSR_defined(0x310) = xlen == 32 // mstatush
Expand Down
Loading