Skip to content

Add support for Zvkg extension #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Zvkg extension #819

wants to merge 1 commit into from
+118 −0

Conversation

nadime15
Copy link
Contributor

@nadime15 nadime15 commented Mar 31, 2025 •
edited
Loading

Add following instructions:

vghsh.vv
vgmul.vv

Tested with riscv-vector-tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited
Loading

Test Results

400 tests  ±0   400 ✅ ±0   1m 49s ⏱️ +2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d42adba. ± Comparison against base commit 0806ed5.

♻️ This comment has been updated with latest results.

jordancarlin
jordancarlin reviewed Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@jordancarlin jordancarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, but looking pretty good. Zvkg also needs to be added to the README.

@nadime15 nadime15 force-pushed the ext_zvkg branch 2 times, most recently from e7535e1 to 97d7e51 Compare March 31, 2025 18:46
@jordancarlin jordancarlin mentioned this pull request Apr 1, 2025
Merged
@nadime15 nadime15 force-pushed the ext_zvkg branch 2 times, most recently from cb3b3d1 to 65f8b47 Compare April 1, 2025 09:30
@nadime15 nadime15 mentioned this pull request Apr 2, 2025
Open
@nadime15
Copy link
Contributor Author

nadime15 commented Apr 2, 2025 •
edited
Loading

Note: The following test case (vghsh and vgmul) fails for VLEN=64 and ELEN=64, which I need to debug:
# Generating tests for VL: 0, LMUL: m2, SEW: e32, Mask: false

Edit: Ok thats strange even though I compiled with VLEN=64 and ran the simulation with zvl64b:

spike --isa=rv64gcv_zvbb_zvbc_zfh_zvfh_zvkg_zvkned_zvknha_zvksed_zvksh_zvl64b_zve64d_zfh_zfhmin_zvfh out/v64x64machine/bin/stage2/vgmul_vv-0

The simulation shows in debug mode that VLEN=128 and ELEN=64. Seems to be Spike related problem.

@nadime15 nadime15 force-pushed the ext_zvkg branch 2 times, most recently from 11caf17 to 97eb6c1 Compare April 3, 2025 09:04
Timmmm
Timmmm reviewed Apr 3, 2025
View reviewed changes
jordancarlin
jordancarlin approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@jordancarlin jordancarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get #835 resolved (and update this accordingly) this seems good to go.

@nadime15
Copy link
Contributor Author

nadime15 commented Apr 6, 2025

I'm currently working on Zvknh[ab], which may introduce changes to riscv_types_zvk.sail. However, it makes sense to finish this PR with only Zvkg in mind and handle the other vector crypto extensions that introduces changes in a separate PR.

@jordancarlin jordancarlin added the extension Adds support for a RISC-V extension label Apr 11, 2025
@Nado15 Nado15 mentioned this pull request Apr 17, 2025
Open
@nadime15 @charmitro
Add support for Zvkg extension
d42adba 
Add following instructions:

vghsh.vv
vgmul.vv

Co-authored-by: Charalampos Mitrodimas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timmmm Timmmm Timmmm left review comments

@jordancarlin jordancarlin jordancarlin approved these changes

Assignees
No one assigned
Labels
extension Adds support for a RISC-V extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadime15 @Timmmm @jordancarlin