starknet_committer: delete patricia paths on reverts#14002
Open
ArielElp wants to merge 1 commit into
Open
Conversation
This was referenced May 7, 2026
|
This change is |
This was referenced May 7, 2026
Contributor
Author
This was referenced May 7, 2026
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
b6af15b to
cc78b2a
Compare
ArielElp
force-pushed
the
ariel/read_paths_and_commit_block
branch
from
a48fffb to
bd02493
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
cc78b2a to
168b164
Compare
ArielElp
force-pushed
the
ariel/read_paths_and_commit_block
branch
from
bd02493 to
a600115
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
168b164 to
2e6e8c8
Compare
ArielElp
force-pushed
the
ariel/read_paths_and_commit_block
branch
from
a600115 to
65906b7
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
2e6e8c8 to
10eb928
Compare
ArielElp
force-pushed
the
ariel/read_paths_and_commit_block
branch
from
65906b7 to
4de5b94
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
2 times, most recently
from
256a296 to
ec63490
Compare
ArielElp
force-pushed
the
ariel/read_paths_and_commit_block
branch
from
4de5b94 to
58e714d
Compare
ArielElp
force-pushed
the
graphite-base/14002
branch
from
535b5e5 to
8508cca
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
2 times, most recently
from
78e768b to
f06a287
Compare
ArielElp
force-pushed
the
graphite-base/14002
branch
2 times, most recently
from
d204c67 to
b7d225e
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
2 times, most recently
from
4333eba to
ece843a
Compare
ArielElp
force-pushed
the
graphite-base/14002
branch
from
b7d225e to
bc61fc5
Compare
ArielElp
changed the base branch from
graphite-base/14002
to
ariel/fetch_patricia_paths_timers
yoavGrs
requested changes
May 26, 2026
Contributor
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on ArielElp).
a discussion (no related file):
Add tests to committer_tests.rs.
It's good to have tests for commit-with-proofs as well, but not in this PR.
ArielElp
force-pushed
the
ariel/fetch_patricia_paths_timers
branch
from
bc61fc5 to
87e4d8a
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
ece843a to
770a6f1
Compare
ArielElp
force-pushed
the
ariel/fetch_patricia_paths_timers
branch
from
87e4d8a to
95ca976
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
770a6f1 to
833273b
Compare
ArielElp
force-pushed
the
ariel/fetch_patricia_paths_timers
branch
from
95ca976 to
b3e1cb3
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
833273b to
a833fd2
Compare
ArielElp
force-pushed
the
ariel/fetch_patricia_paths_timers
branch
from
b3e1cb3 to
32e6027
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
a833fd2 to
096d9a1
Compare
ArielElp
force-pushed
the
ariel/fetch_patricia_paths_timers
branch
from
32e6027 to
c485dfa
Compare
ArielElp
force-pushed
the
ariel/revert_logic
branch
from
096d9a1 to
88fbdfb
Compare
ArielElp
force-pushed
the
ariel/fetch_patricia_paths_timers
branch
from
c485dfa to
c2f9a34
Compare
ArielElp
commented
May 27, 2026
Contributor
Author
ArielElp
left a comment
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on yoavGrs).
a discussion (no related file):
Previously, yoavGrs wrote…
Add tests to
committer_tests.rs.It's good to have tests for commit-with-proofs as well, but not in this PR.
Done in next PR
yoavGrs
approved these changes
May 27, 2026
Contributor
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.