Skip to content

apollo_committer,starknet_committer: use blockifier's AccessedKeys#14252

Open
ArielElp wants to merge 1 commit into
ariel/add_request_handlerfrom
ariel/switch_to_blockifier_accessed_keys
Open

apollo_committer,starknet_committer: use blockifier's AccessedKeys#14252
ArielElp wants to merge 1 commit into
ariel/add_request_handlerfrom
ariel/switch_to_blockifier_accessed_keys

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp changed the base branch from ariel/add_request_handler to graphite-base/14252 May 28, 2026 15:29
@ArielElp ArielElp marked this pull request as ready for review May 31, 2026 10:43
@cursor
Copy link
Copy Markdown

cursor Bot commented May 31, 2026

PR Summary

Medium Risk
Touches OS input, committer witness collection, and proof/commitment construction; behavior should be equivalent but any mismatch between AccessedKeys and prior StateChangesKeys shaping could affect witness digests or proofs.

Overview
This PR standardizes trie witness / Patricia path inputs on blockifier’s AccessedKeys instead of ad‑hoc vectors, StateChangesKeys, or duplicate committer types.

starknet_committer now depends on blockifier and builds LeavesRequest via From<&AccessedKeys>, with sorting moved to LeavesRequest::sorted(). fetch_previous_and_new_patricia_paths takes &AccessedKeys directly, removing manual class/contract/storage folding at each call site.

apollo_committer’s read_paths_and_commit_block uses that path end‑to‑end (no local key unpacking). StateCommitmentInfos::new in starknet_os and the transaction prover / flow tests pass &AccessedKeys (and From<StateChangesKeys> where initial reads still use StateChangesKeys).

Cargo.lock reflects the new starknet_committer → blockifier edge.

Reviewed by Cursor Bugbot for commit a5ac682. Bugbot is set up for automated code reviews on this repo. Configure here.

@ArielElp ArielElp force-pushed the graphite-base/14252 branch from 74ed1a0 to b46768a Compare May 31, 2026 13:47
@ArielElp ArielElp force-pushed the ariel/switch_to_blockifier_accessed_keys branch from 53fa580 to 5fc1b5d Compare May 31, 2026 13:47
@ArielElp ArielElp changed the base branch from graphite-base/14252 to ariel/add_request_handler May 31, 2026 13:48
@ArielElp ArielElp force-pushed the ariel/switch_to_blockifier_accessed_keys branch from 5fc1b5d to c805f67 Compare May 31, 2026 14:41
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from b46768a to 715e282 Compare May 31, 2026 14:41
@ArielElp ArielElp force-pushed the ariel/switch_to_blockifier_accessed_keys branch from c805f67 to 97e9ad4 Compare May 31, 2026 17:03
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch 2 times, most recently from d6c7ffb to df29941 Compare June 1, 2026 08:24
@ArielElp ArielElp force-pushed the ariel/switch_to_blockifier_accessed_keys branch from 97e9ad4 to a4466a7 Compare June 1, 2026 08:24
@ArielElp ArielElp force-pushed the ariel/switch_to_blockifier_accessed_keys branch from a4466a7 to a5ac682 Compare June 1, 2026 08:41
@ArielElp ArielElp requested a review from yoavGrs June 1, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants