apollo_committer: add new request handler#14003
Conversation
3bb9c52 to
cd31e55
Compare
b6af15b to
cc78b2a
Compare
cd31e55 to
1525ea7
Compare
cc78b2a to
168b164
Compare
bc9526b to
7f3cc68
Compare
2e6e8c8 to
10eb928
Compare
7f3cc68 to
e791353
Compare
256a296 to
ec63490
Compare
e791353 to
b63892f
Compare
492a6ac to
1c1a8a6
Compare
ece843a to
770a6f1
Compare
24bfc40 to
837ec3a
Compare
833273b to
a833fd2
Compare
837ec3a to
a983994
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 4 files and all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved.
a983994 to
464e6e8
Compare
096d9a1 to
88fbdfb
Compare
464e6e8 to
beab8a9
Compare
beab8a9 to
fa8519b
Compare
88fbdfb to
e720964
Compare
fa8519b to
b5a5268
Compare
e720964 to
9c253a8
Compare
9c253a8 to
8a3d6fb
Compare
b5a5268 to
20bdbc6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 98a2d45. Configure here.
| ) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Duplicated handler arms risk diverging across feature-gated impls
Low Severity
The CommitBlock and RevertBlock match arms in handle_request are fully duplicated across the #[cfg(not(feature = "os_input"))] and #[cfg(feature = "os_input")] impl blocks. If future changes update one arm (e.g., adding logging, wrapping the response, or handling a new variant) without updating the other, the two feature-gated paths silently diverge. The split is needed because the two impls have different trait bounds, but the shared logic could be extracted into a helper method on Committer to avoid the duplication.
Reviewed by Cursor Bugbot for commit 98a2d45. Configure here.
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and made 1 comment.
Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on ArielElp).
crates/apollo_committer_types/src/communication.rs line 68 at r5 (raw file):
RevertBlock(RevertBlockRequest), #[cfg(feature = "os_input")] ReadPathsAndCommitBlock(ReadPathsAndCommitBlockRequest),
Consider not adding a new variant, as the committer blocks commit_block API under os_input.
Code quote:
#[cfg(feature = "os_input")]
ReadPathsAndCommitBlock(ReadPathsAndCommitBlockRequest),
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on ArielElp).
crates/apollo_committer_types/src/communication.rs line 68 at r5 (raw file):
Previously, yoavGrs wrote…
Consider not adding a new variant, as the committer blocks
commit_blockAPI underos_input.
Or set the commit block under not "os_input". WDYT?



No description provided.