Skip to content

apollo_committer: add new request handler#14003

Open
ArielElp wants to merge 1 commit into
ariel/test_revert_flow_with_witnessesfrom
ariel/add_request_handler
Open

apollo_committer: add new request handler#14003
ArielElp wants to merge 1 commit into
ariel/test_revert_flow_with_witnessesfrom
ariel/add_request_handler

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented May 7, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 7, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from 3bb9c52 to cd31e55 Compare May 7, 2026 12:40
@ArielElp ArielElp force-pushed the ariel/revert_logic branch from b6af15b to cc78b2a Compare May 7, 2026 12:40
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from cd31e55 to 1525ea7 Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/revert_logic branch from cc78b2a to 168b164 Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch 2 times, most recently from bc9526b to 7f3cc68 Compare May 18, 2026 13:52
@ArielElp ArielElp force-pushed the ariel/revert_logic branch from 2e6e8c8 to 10eb928 Compare May 18, 2026 13:52
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from 7f3cc68 to e791353 Compare May 19, 2026 06:55
@ArielElp ArielElp force-pushed the ariel/revert_logic branch from 256a296 to ec63490 Compare May 19, 2026 07:08
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from e791353 to b63892f Compare May 19, 2026 07:08
@ArielElp ArielElp marked this pull request as ready for review May 19, 2026 07:08
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from 492a6ac to 1c1a8a6 Compare May 25, 2026 14:13
@ArielElp ArielElp force-pushed the ariel/revert_logic branch from ece843a to 770a6f1 Compare May 26, 2026 10:08
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch 2 times, most recently from 24bfc40 to 837ec3a Compare May 26, 2026 10:48
@ArielElp ArielElp force-pushed the ariel/revert_logic branch 2 times, most recently from 833273b to a833fd2 Compare May 26, 2026 11:42
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from 837ec3a to a983994 Compare May 26, 2026 11:42
Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 4 files and all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved.

@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from a983994 to 464e6e8 Compare May 26, 2026 13:03
@ArielElp ArielElp force-pushed the ariel/revert_logic branch from 096d9a1 to 88fbdfb Compare May 26, 2026 13:11
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from 464e6e8 to beab8a9 Compare May 26, 2026 13:11
@ArielElp ArielElp changed the base branch from ariel/revert_logic to graphite-base/14003 May 27, 2026 07:22
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from beab8a9 to fa8519b Compare May 27, 2026 07:23
@ArielElp ArielElp force-pushed the graphite-base/14003 branch from 88fbdfb to e720964 Compare May 27, 2026 07:23
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from fa8519b to b5a5268 Compare May 27, 2026 09:45
@ArielElp ArielElp force-pushed the graphite-base/14003 branch from e720964 to 9c253a8 Compare May 27, 2026 09:45
@ArielElp ArielElp changed the base branch from graphite-base/14003 to ariel/test_revert_flow_with_witnesses May 27, 2026 09:46
@ArielElp ArielElp force-pushed the ariel/test_revert_flow_with_witnesses branch from 9c253a8 to 8a3d6fb Compare May 27, 2026 11:52
@ArielElp ArielElp force-pushed the ariel/add_request_handler branch from b5a5268 to 20bdbc6 Compare May 27, 2026 11:52
Comment thread crates/apollo_committer_types/src/committer_types.rs
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 98a2d45. Configure here.

)
}
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated handler arms risk diverging across feature-gated impls

Low Severity

The CommitBlock and RevertBlock match arms in handle_request are fully duplicated across the #[cfg(not(feature = "os_input"))] and #[cfg(feature = "os_input")] impl blocks. If future changes update one arm (e.g., adding logging, wrapping the response, or handling a new variant) without updating the other, the two feature-gated paths silently diverge. The split is needed because the two impls have different trait bounds, but the shared logic could be extracted into a helper method on Committer to avoid the duplication.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 98a2d45. Configure here.

Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 2 files and made 1 comment.
Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on ArielElp).


crates/apollo_committer_types/src/communication.rs line 68 at r5 (raw file):

    RevertBlock(RevertBlockRequest),
    #[cfg(feature = "os_input")]
    ReadPathsAndCommitBlock(ReadPathsAndCommitBlockRequest),

Consider not adding a new variant, as the committer blocks commit_block API under os_input.

Code quote:

    #[cfg(feature = "os_input")]
    ReadPathsAndCommitBlock(ReadPathsAndCommitBlockRequest),

Copy link
Copy Markdown
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs made 1 comment.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on ArielElp).


crates/apollo_committer_types/src/communication.rs line 68 at r5 (raw file):

Previously, yoavGrs wrote…

Consider not adding a new variant, as the committer blocks commit_block API under os_input.

Or set the commit block under not "os_input". WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants