starknet_committer: extract commit plan to commit_or_load

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer: fetch patricia paths concurrently #14283
• starknet_committer: define fetch_contract_storage_paths_concurrently #14282
• starknet_committer: define StoragePathsReadTask #14281
• starknet_patricia_storage: move is_gatherable to ReadOnlyStorage #14280
• apollo_committer,starknet_committer: use blockifier's AccessedKeys #14252
• apollo_committer: add new request handler #14003
• apollo_committer: add request_paths_and_commit_block tests #14208
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999 👈 (View in Graphite)
• starknet_committer: read and write patricia paths to index db #13998
• apollo_committer_types: add patricia proofs request and response types #13996 : 1 other dependent PR (#13997 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/apollo_committer/src/committer.rs line 98 at r2 (raw file):

    /// `height` is already committed; return the stored global root without writing.
    Historical { global_root: GlobalRoot },
    /// `height` is the chain tip; inputs are validated and ready to commit.

Suggestion:

/// `height` is the next uncommitted offset;

---

crates/apollo_committer/src/committer.rs line 207 at r2 (raw file):

                update_metrics(height, &block_measurements.block_measurement);
                self.update_offset(next_offset);
                Ok(CommitBlockResponse { global_root })

no changes here, right? cut-paste?

Code quote:

                // Happy flow. Commits the state diff and returns the computed global root.
                debug!(
                    "Committing block number {height} with state diff {state_diff_commitment:?}"
                );
                let mut block_measurements = SingleBlockMeasurements::default();
                block_measurements.start_measurement(Action::EndToEnd);
                let CommitStateDiffOutput { filled_forest, global_root, deleted_nodes } =
                    self.commit_state_diff(state_diff, &mut block_measurements).await?;
                let next_offset = height.unchecked_next();
                let metadata = HashMap::from([
                    (
                        ForestMetadataType::CommitmentOffset,
                        DbValue(DbBlockNumber(next_offset).serialize().to_vec()),
                    ),
                    (
                        ForestMetadataType::StateRoot(DbBlockNumber(height)),
                        serialize_felt_no_packing(global_root.0),
                    ),
                    (
                        ForestMetadataType::StateDiffHash(DbBlockNumber(height)),
                        serialize_felt_no_packing(state_diff_commitment.0.0),
                    ),
                ]);
                info!(
                    "For block number {height}, writing filled forest to storage with metadata: \
                     {metadata:?}, delete {} nodes",
                    deleted_nodes.len()
                );
                block_measurements.start_measurement(Action::Write);
                let n_write_entries = self
                    .forest_storage
                    .write_with_metadata(&filled_forest, metadata, deleted_nodes)
                    .await
                    .map_err(|err| self.map_internal_error(err))?;
                block_measurements.attempt_to_stop_measurement(Action::Write, n_write_entries).ok();
                block_measurements.attempt_to_stop_measurement(Action::EndToEnd, 0).ok();
                update_metrics(height, &block_measurements.block_measurement);
                self.update_offset(next_offset);
                Ok(CommitBlockResponse { global_root })

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/apollo_committer/src/committer.rs line 207 at r2 (raw file):

Previously, dorimedini-starkware wrote…

no changes here, right? cut-paste?

yes

---

crates/apollo_committer/src/committer.rs line 98 at r2 (raw file):

    /// `height` is already committed; return the stored global root without writing.
    Historical { global_root: GlobalRoot },
    /// `height` is the chain tip; inputs are validated and ready to commit.

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[graphite-app]

Merge activity

• May 28, 2:58 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).