Skip to content

starknet_os: os resources test - declare tx#14147

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_declare_tx
Open

starknet_os: os resources test - declare tx#14147
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_declare_tx

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Changes are regression tests and versioned-constants snapshots for OS resource accounting; no production execution-path logic beyond updated fee constants.

Overview
Extends the OS execute_txs_inner resource regression test so it measures declare transactions alongside invoke, not invoke alone.

The test runs a minimal declare using a fixed data-gas account class (unchanged artifacts for stable numbers), subtracts blockifier business-logic resources from full OS trace resources, and writes the remaining constant declare overhead into blockifier_versioned_constants_0_14_4.json (e.g. 3938 steps, 92 range-check builtins vs the previous 3523 / 72).

The deployable-for-resource-measurement account contract gains a stub __validate_declare__ entry point with matching CASM/Sierra updates so validation paths stay consistent. Minor formatting-only edits appear in the OS resources test Cairo source.

Reviewed by Cursor Bugbot for commit b73625a. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from fbfd93e to f4340dd Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch 2 times, most recently from c632d3d to e678a92 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from f4340dd to 25d975a Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from e678a92 to c2f6aca Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 25d975a to 96d404c Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from c2f6aca to 350efcf Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 96d404c to 1e60c06 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 1e60c06 to d1652f9 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from d1652f9 to b73625a Compare June 1, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants