starknet_os: os resources test - extract setup_test_builder#14145
Conversation
PR SummaryLow Risk Overview The helper centralizes deploying and funding the OS-resources account contract, forcing step tracking via
Reviewed by Cursor Bugbot for commit dc1d752. Bugbot is set up for automated code reviews on this repo. Configure here. |
e669ac7 to
f5a424e
Compare
d2589c6 to
15ddac2
Compare
f5a424e to
ac5afa2
Compare
f52aba2 to
dfe2b69
Compare
379da51 to
0493b58
Compare
0493b58 to
fda71dc
Compare
dfe2b69 to
260dc52
Compare
fda71dc to
7da49c7
Compare
260dc52 to
4495063
Compare
7da49c7 to
e890ed1
Compare
4495063 to
7fe2ce8
Compare
e890ed1 to
cac8672
Compare
7fe2ce8 to
5531f10
Compare
5531f10 to
8e42748
Compare
8e42748 to
dc1d752
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
…_fee_transfer_syscalls test_fee_transfer_syscalls only needs the OS-resources contract, yet setup_test_builder (introduced in #14145) unconditionally declares and deploys the stable contract (two full Cairo-execution transactions). The stable_contract_address and stable_contract_class_hash fields were silently discarded via `..` destructuring, wasting test runtime. Fix: - Remove stable-contract setup and move_to_next_block from setup_test_builder; each call site does its own block-advance so the block ordering for test_os_resources_regression is preserved. - Drop the now-unused ClassHash import. - test_fee_transfer_syscalls no longer pays for two extra tx executions.

No description provided.