Skip to content

starknet_os: os resources test - extract setup_test_builder#14145

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-24-starknet_os_os_resources_test_-_extract_setup_test_builder
Jun 24, 2026
Merged

starknet_os: os resources test - extract setup_test_builder#14145
dorimedini-starkware merged 1 commit into
mainfrom
05-24-starknet_os_os_resources_test_-_extract_setup_test_builder

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor in flow tests; the fee-transfer test’s initial state is slightly richer but assertions are unchanged.

Overview
Refactors os_resources_test.rs by pulling shared test harness setup into setup_test_builder and an OsResourcesTestSetup struct, so test_fee_transfer_syscalls and test_os_resources_regression no longer duplicate the same boilerplate.

The helper centralizes deploying and funding the OS-resources account contract, forcing step tracking via min_sierra_version_for_sierra_gas = (99, 99, 99), declaring/deploying the stable measurement contract, and advancing to the next block. An optional raw_vc argument optionally **assert_eq!**s versioned constants against the block context (used by the regression test).

test_fee_transfer_syscalls now calls the shared helper with None instead of TestBuilder::create_standard, so it runs on the same richer initial state as the regression test (stable contract + block advance), while still only asserting fee-transfer syscalls on the measurement invoke.

Reviewed by Cursor Bugbot for commit dc1d752. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from e669ac7 to f5a424e Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from d2589c6 to 15ddac2 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from f5a424e to ac5afa2 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to 05-23-starknet_os_os_resources_test_-_add_secp_syscalls June 11, 2026 13:05
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 11, 2026 16:57
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from f52aba2 to dfe2b69 Compare June 11, 2026 16:58
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to 05-23-starknet_os_os_resources_test_-_add_secp_syscalls June 11, 2026 16:58
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 13, 2026 12:36
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from dfe2b69 to 260dc52 Compare June 13, 2026 15:34
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to 05-23-starknet_os_os_resources_test_-_add_secp_syscalls June 13, 2026 15:34
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 14, 2026 09:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 260dc52 to 4495063 Compare June 20, 2026 11:51
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to 05-23-starknet_os_os_resources_test_-_add_secp_syscalls June 20, 2026 11:51
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 20, 2026 13:09
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 4495063 to 7fe2ce8 Compare June 20, 2026 13:09
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to 05-23-starknet_os_os_resources_test_-_add_secp_syscalls June 20, 2026 13:09
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 21, 2026 12:51
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 7fe2ce8 to 5531f10 Compare June 21, 2026 12:52
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to main June 21, 2026 12:52
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 5531f10 to 8e42748 Compare June 21, 2026 14:27
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 8e42748 to dc1d752 Compare June 23, 2026 13:54

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit c9b0b50 Jun 24, 2026
20 checks passed
gkaempfer added a commit that referenced this pull request Jun 24, 2026
…_fee_transfer_syscalls

test_fee_transfer_syscalls only needs the OS-resources contract, yet
setup_test_builder (introduced in #14145) unconditionally declares and
deploys the stable contract (two full Cairo-execution transactions).
The stable_contract_address and stable_contract_class_hash fields were
silently discarded via `..` destructuring, wasting test runtime.

Fix:
- Remove stable-contract setup and move_to_next_block from
  setup_test_builder; each call site does its own block-advance so
  the block ordering for test_os_resources_regression is preserved.
- Drop the now-unused ClassHash import.
- test_fee_transfer_syscalls no longer pays for two extra tx executions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants