Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpiutil] Rename create event and semaphore #7336

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[wpiutil] Rename create event and semaphore #7336

wants to merge 4 commits into from
+42 −42

Conversation

spacey-sooty
Copy link
Contributor

Resolves #7303

@spacey-sooty spacey-sooty requested review from PeterJohnson and a team as code owners November 4, 2024 03:25
@spacey-sooty
Copy link
Contributor Author

/format

@spacey-sooty spacey-sooty force-pushed the rename-create-event-and-sephamore branch from 12e243c to 98b2b51 Compare November 4, 2024 04:28
@spacey-sooty
Copy link
Contributor Author

/format

@PeterJohnson PeterJohnson changed the title Rename create event and sephamore Rename create event and semaphore Nov 5, 2024
PeterJohnson
PeterJohnson requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@PeterJohnson PeterJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also update the Java/JNI functions to match the naming.

@spacey-sooty spacey-sooty force-pushed the rename-create-event-and-sephamore branch from 1909d41 to 64e23d8 Compare November 6, 2024 03:47
@spacey-sooty
Copy link
Contributor Author

/format

@spacey-sooty spacey-sooty force-pushed the rename-create-event-and-sephamore branch from b6dee4c to b130e4a Compare November 7, 2024 03:13
@spacey-sooty
Copy link
Contributor Author

/format

@calcmogul calcmogul changed the title Rename create event and semaphore [wpiutil] Rename create event and semaphore Nov 16, 2024
@spacey-sooty spacey-sooty force-pushed the rename-create-event-and-sephamore branch from 83c0d9a to 7066ea9 Compare December 19, 2024 13:25
@github-actions github-actions bot added component: wpiutil WPI utility library component: wpilibj WPILib Java component: wpinet WPI networking library component: examples labels Dec 19, 2024
@spacey-sooty
fmt
8804104 
Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty
Copy link
Contributor Author

Should this be retargeted to 2027 or is it fine to be merged as a 2026 patch?

@PeterJohnson
Copy link
Member

We should retarget it to 2027. Need to decide if we want a bigger C++ rename for 2027 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson Awaiting requested review from PeterJohnson PeterJohnson is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component: examples component: wpilibj WPILib Java component: wpinet WPI networking library component: wpiutil WPI utility library
Projects
2027
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename wpi::CreateEvent and wpi::CreateSemaphore
2 participants
@spacey-sooty @PeterJohnson