Skip to content

Add wait function that utilizes sim clock #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Feb 17, 2023

  • User level function needs a better name (or should it just replace the Wait/delay functions entirely?)
  • C++ tests need to be written
  • Need to rewrite the java test- theres still a race condition, and the test is kinda sketchy. (ignore the test for now)

@rzblue rzblue force-pushed the sim-wait branch 4 times, most recently from e40254e to 2734516 Compare June 1, 2023 22:04
@rzblue rzblue marked this pull request as ready for review June 1, 2023 22:11
@rzblue rzblue requested review from a team as code owners June 1, 2023 22:11
@rzblue
Copy link
Member Author

rzblue commented Jun 1, 2023

I think this is a good feature to have, but could be a footgun in unit testing- if this is called while timing is disabled in a single thread it will deadlock that thread.

Need to figure out naming as well.

@rzblue rzblue added the component: hal Hardware Abstraction Layer label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hal Hardware Abstraction Layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant