Make RuntimeLoader fall back to temp directory #5851
Draft
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be closed now RuntimeLoader has been almost entirely removed correct? |
|
Is the underlying issue (native libraries can't be loaded in read only mode) still present? If yes, a similar PR but rebased on master would still be valuable I think. |
|
Is there any interest in pushing this forwards? I still think wpilib supporting loading JNI libraries on read-only filesystems is a valuable feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5846 (native library extraction failing if ~ is read-only)
Still up for debate is how CombinedRuntimeLoader should handle this. I'm inclined to just warn users and make them deal with trying again after calling
setExtractionDirectory?