[cmd] Add Command.repeatedly(int count) #6589

kytpbs · 2024-05-06T00:58:28Z

Currently, the unit tests fail and there are a lot of print statements for whoever might be checking into this.

The problem is. The exact same function calls create different results between C++ and Java. I may just be the idiot but it seems to require further look into

The debug's are in different commits making it a lot easier to revert them if needed.

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java

spacey-sooty

Overall looks good just a few comments. Dunno why C++ would print stuff out especially since Java doesn't, along with this for printing in C++ its generally better to use fmt::print()

wpilibNewCommands/src/main/native/cpp/frc2/command/CommandScheduler.cpp

wpilibNewCommands/src/main/native/cpp/frc2/command/CommandPtr.cpp

wpilibNewCommands/src/main/native/cpp/frc2/command/CommandScheduler.cpp

kytpbs · 2024-05-06T12:12:22Z

/format

KangarooKoala · 2024-05-12T21:25:34Z

This was stated in Discord, but tests are probably failing because of an inconsistent order of when the commands in the internal deadline group are checked, which should be fixed by #6602.

kytpbs · 2024-10-07T01:17:03Z

Thanks to #6602 being merged, the tests pass correctly.

I reverted back the print code and rebased them out for a cleaner history.

KangarooKoala

Nice! Overall looks good, just a few small things.

wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandDecoratorTest.java

wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp

wpilibNewCommands/src/main/native/cpp/frc2/command/CommandPtr.cpp

kytpbs · 2024-10-10T22:05:22Z

fix formatting with rebase + force push:

KangarooKoala

Looks good to me, for what it's worth.

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java

wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandDecoratorTest.java

wpilibNewCommands/src/main/native/include/frc2/command/Command.h

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java

wpilibNewCommands/src/main/native/include/frc2/command/CommandPtr.h

wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp

kytpbs · 2024-12-16T14:51:46Z

/format

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java

KangarooKoala · 2024-12-16T16:10:57Z

wpilibNewCommands/src/main/native/include/frc2/command/Command.h

+   * Decorates this command to run repeatedly until the given count is reached
+   * or is interrupted. The decorated command can still be canceled.


We should either make Java match C++ or C++ match Java. (I don't have a particularly strong preference on which one)
This also applies to the CommandPtr doc comment.

This would mean we would neet to also change the documentation on the .repeating() function.

IMO, it would be better if this PR didn't have any line removals

This would mean we would neet to also change the documentation on the .repeating() function.

How so? I'm just talking about changing the repeatedly(int) doc comments.

Also, the wording that would most match the repeatedly() doc comment (in both Java and C++) is "Decorates this command to run repeatedly, restarting it when it ends, until this command is run the specified number of times or is interrupted. The decorated command can still be canceled."

Co-authored-by: Joseph Eng <[email protected]>

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java

wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp

KangarooKoala

Great work! There's just a few things left:

The Java and C++ doc comments still need to be updated (see this comment).
Pick a consistent name for the parameter (repetitions or counts) and make sure the parameter doc comments are the same between Java and C++.

wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp

Also adds Java Consistency

kytpbs · 2025-01-31T18:05:21Z

/format

KangarooKoala

Great work! Unfortunately the last 10% of polishing takes a while, but you're almost there.

wpilibNewCommands/src/main/native/include/frc2/command/CommandPtr.h

wpilibNewCommands/src/main/native/cpp/frc2/command/Command.cpp

Co-Authored-By: Joseph Eng <[email protected]>

kytpbs · 2025-11-15T09:17:50Z

The last 10% of polishing takes a while

That sure took a while, alright. Sorry, I kinda left the PRs just abandoned for a bit, life got a bit in the way

kytpbs requested review from a team as code owners May 6, 2024 00:58

Starlight220 reviewed May 6, 2024

View reviewed changes

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java Show resolved Hide resolved

spacey-sooty reviewed May 6, 2024

View reviewed changes

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch 7 times, most recently from c21b4cf to 832d5a0 Compare October 7, 2024 00:50

kytpbs requested a review from spacey-sooty October 7, 2024 01:17

spacey-sooty approved these changes Oct 7, 2024

View reviewed changes

kytpbs requested a review from Starlight220 October 7, 2024 01:27

Starlight220 previously approved these changes Oct 7, 2024

View reviewed changes

KangarooKoala approved these changes Oct 7, 2024

View reviewed changes

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch from 832d5a0 to e122b0c Compare October 10, 2024 13:29

kytpbs dismissed Starlight220’s stale review via f0d8608 October 10, 2024 21:54

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch from f0d8608 to b569c8f Compare October 10, 2024 22:05

kytpbs requested a review from Starlight220 October 10, 2024 23:07

KangarooKoala approved these changes Oct 12, 2024

View reviewed changes

rzblue requested changes Nov 12, 2024

View reviewed changes

github-actions bot added the component: command-based WPILib Command Based Library label Dec 16, 2024

PeterJohnson requested review from a team and PeterJohnson as code owners December 16, 2024 14:55

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch 2 times, most recently from 3a36e0d to cd2328e Compare December 16, 2024 15:55

KangarooKoala reviewed Dec 16, 2024

View reviewed changes

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch 3 times, most recently from 57ceb5b to 7be3682 Compare December 16, 2024 18:13

kytpbs and others added 2 commits December 17, 2024 22:14

Better comments and variable names

9fec4bc

More explicitly set initial counter value

f31b58c

Co-authored-by: Joseph Eng <[email protected]>

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch from 7be3682 to f31b58c Compare December 17, 2024 21:15

Starlight220 reviewed Dec 18, 2024

View reviewed changes

wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java Outdated Show resolved Hide resolved

wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp Show resolved Hide resolved

Improve comments & Add failure messages to C++

d968cb3

Starlight220 previously approved these changes Dec 23, 2024

View reviewed changes

KangarooKoala reviewed Dec 23, 2024

View reviewed changes

wpilibNewCommands/src/test/native/cpp/frc2/command/CommandDecoratorTest.cpp Outdated Show resolved Hide resolved

kytpbs added 2 commits January 31, 2025 21:00

Improve method docs

54aa6c9

Better Test Expectations in C++

5e9b756

Also adds Java Consistency

kytpbs dismissed Starlight220’s stale review via 5e9b756 January 31, 2025 18:01

Formatting

89f4a5f

KangarooKoala reviewed Feb 1, 2025

View reviewed changes

calcmogul changed the title ~~Add command.repeatdly(int count) to both java and c++~~ [cmd] Add Command.repeatdly(int count) Sep 27, 2025

github-actions bot removed component: wpiutil Utility library component: wpilibj WPILib Java component: wpilibc WPILib C++ component: hal Hardware Abstraction Layer component: wpimath Math library component: wpiunits Java units library labels Nov 15, 2025

improve variable names & func docs

e6b7f42

Co-Authored-By: Joseph Eng <[email protected]>

kytpbs force-pushed the add-Command.Repeatdly(int-count) branch from c1c346a to e6b7f42 Compare November 15, 2025 09:12

calcmogul changed the title ~~[cmd] Add Command.repeatdly(int count)~~ [cmd] Add Command.repeatedly(int count) Jan 17, 2026

		* Decorates this command to run repeatedly until the given count is reached
		* or is interrupted. The decorated command can still be canceled.

[cmd] Add Command.repeatedly(int count) #6589

Are you sure you want to change the base?

[cmd] Add Command.repeatedly(int count) #6589

Conversation

kytpbs commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

spacey-sooty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kytpbs commented May 6, 2024

Uh oh!

KangarooKoala commented May 12, 2024

Uh oh!

kytpbs commented Oct 7, 2024

Uh oh!

KangarooKoala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kytpbs commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KangarooKoala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kytpbs commented Dec 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KangarooKoala Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

kytpbs Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

KangarooKoala Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KangarooKoala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kytpbs commented Jan 31, 2025

Uh oh!

KangarooKoala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kytpbs commented Nov 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kytpbs commented May 6, 2024 •

edited

Loading

kytpbs commented Oct 10, 2024 •

edited

Loading