[wpimath] Fix Debouncer type-changing behavior #7870
+12
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes wpilibsuite#7867 Properly resets the baseline upon switching the debounce type, and adds a test for such. Signed-off-by: swurl <[email protected]>
calcmogul
requested changes
Mar 19, 2025
Signed-off-by: swurl <[email protected]>
|
Changed everything in the constructor as well for the sake of consistency. |
calcmogul
approved these changes
Mar 19, 2025
|
When changing the debounce time, does the timer need to be reset like in the constructor? |
|
Either way seems valid to me. |
|
I'll leave it as is and if someone requests the change we can change it pretty easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7867
Properly resets the baseline upon switching the debounce type, and adds
a test for such.
Signed-off-by: swurl [email protected]