[wpimath] fix null pointer when calling timeLeftUntill #7894
+26
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-it-is
changed the title
me-it-is
changed the title
calcmogul
requested changes
Apr 8, 2025
wpimath/src/main/java/edu/wpi/first/math/trajectory/TrapezoidProfile.java
Outdated
Show resolved
Hide resolved
wpimath/src/test/native/cpp/trajectory/TrapezoidProfileTest.cpp
Outdated
Show resolved
Hide resolved
wpimath/src/test/java/edu/wpi/first/math/trajectory/TrapezoidProfileTest.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/trajectory/TrapezoidProfile.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/trajectory/TrapezoidProfile.java
Outdated
Show resolved
Hide resolved
|
Closes #6452 |
calcmogul
requested changes
Apr 8, 2025
wpimath/src/main/native/include/frc/trajectory/TrapezoidProfile.h
Outdated
Show resolved
Hide resolved
wpimath/src/test/native/cpp/trajectory/TrapezoidProfileTest.cpp
Outdated
Show resolved
Hide resolved
wpimath/src/test/java/edu/wpi/first/math/trajectory/TrapezoidProfileTest.java
Outdated
Show resolved
Hide resolved
calcmogul
previously approved these changes
Apr 9, 2025
|
The C++ compiler says there's some other initialization bugs to fix. wpiformat CI has a patch file you can apply to fix the formatting. |
me-it-is
force-pushed
the
main
branch
3 times, most recently
from
3f07ca8 to
02fde3c
Compare
calcmogul
requested changes
Apr 16, 2025
calcmogul
previously approved these changes
Apr 16, 2025
calcmogul
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the null pointer and adds docs to clarify the return value in this case or when calling totalTime.