Skip to content

Conversation

@pjreiniger
Copy link
Contributor

Resync with mostrobotpy

This mostly involves the big "ignore almost everything in the HAL project" and some fixups for the Addressable LED classes.

Required two small hand fixes to get it building over here with bazel, and with more compiler warnings on.

I also manually zeroed out the repo_url field in the toml files to avoid unnecessary churn whenever it goes from a release build to a development build. I already did this with version field in there, and will do a follow up PR that updates the copybara script to do it automatically.

@pjreiniger pjreiniger requested review from a team and PeterJohnson as code owners December 21, 2025 05:20
@github-actions github-actions bot added component: ntcore NetworkTables library component: wpiutil Utility library component: wpilibc WPILib C++ component: hal Hardware Abstraction Layer component: wpimath Math library component: wpinet Networking library component: apriltag AprilTag library 2027 2027 target labels Dec 21, 2025
auscompgeek
auscompgeek previously approved these changes Dec 21, 2025
Copy link
Member

@PeterJohnson PeterJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple changes to repo URLs that had been set for 2027; did something change to make these no longer necessary?

@pjreiniger
Copy link
Contributor Author

Multiple changes to repo URLs that had been set for 2027; did something change to make these no longer necessary?

I zero'd out the version field in the original copybara scripts, because it similarly isn't used by the bazel scripts. I didn't think about repo_url at the time, since it changes far less often than version would, but is still annoying.

PeterJohnson pushed a commit that referenced this pull request Dec 24, 2025
This is a high churn change whenever `mostrobotpy` switches from
pointing to `release-2027` to `development-2027`. The value isn't used
by the bazel build scripts, so there is no reason to have a zero impact
change on ~11 files muddying up the synchronization diffs.

In the `allwpilib -> mostrobotpy` direction, we update [this
](https://github.com/robotpy/mostrobotpy/blob/main/rdev.toml) config
file and run
[this](https://github.com/robotpy/mostrobotpy/blob/main/rdev.sh) script
which updates it in that repo during.

I manually did this change in #8503, but this will do it automatically
in the future
@pjreiniger
Copy link
Contributor Author

Now updated to include this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2027 2027 target component: apriltag AprilTag library component: hal Hardware Abstraction Layer component: ntcore NetworkTables library component: wpilibc WPILib C++ component: wpimath Math library component: wpinet Networking library component: wpiutil Utility library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants