[workspace] Upgrade osqp_internal,qdldl_internal to latest #22870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: do not merge
status: do not review
release notes: fix
jwnimmer-tri
force-pushed
the
upgrade-osqp
branch
2 times, most recently
from
c6d052c to
fb83c8e
Compare
|
+@hongkai-dai maybe you can help me out here? OSQP has released a major upgrade to 1.0.0. (See link atop the pull request.) I believe I've adapted the build system and API calls correctly now, but I there are still test failures. Several tests are testing to tolerance 1e-10 but OSQP results are around 1e-6. I wonder if possibly some OSQP defaults have changed? Or my code changes to the settings handling are wrong? Do you have some time to investigate? |
Upgrade osqp_internal to latest release 1.0.0. Upgrade qdldl_internal to latest release 0.1.8.
From an eyeball skim of the two OSQP releases, I don't see any defaults that have changed. There are a few new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSQP repaved a lot of their API in this release. See https://github.com/osqp/osqp/blob/master/docs/get_started/migration_guide.rst for details.
This PR is still a WIP for now, while I continue adapting to the changes.
Upgrade osqp_internal to latest release v1.0.0.
Upgrade qdldl_internal to latest release v0.1.8.
This change is