Skip to content

[workspace] Upgrade vtk_internal to latest commit #22981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Aiden2244
Copy link
Contributor

@Aiden2244 Aiden2244 commented May 6, 2025

Towards #22928


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

FYI It seems like the problem is the diagnostic observer added in #21090 is no longer effective -- VTK is raising errors globally instead of feeding them through the diagnostic infrastructure. Here is the code that's supposed to observe the error:

vtkNew<vtkGLTFImporter> importer;
observe(importer);
const MeshSource& mesh_source = mesh.source();
if (mesh_source.is_path()) {
importer->SetFileName(mesh_source.path().c_str());
} else {
vtkNew<VtkGltfUriLoader> uri_loader;
uri_loader->SetMeshSource(&mesh_source);
vtkSmartPointer<vtkResourceStream> gltf_stream =
uri_loader->MakeGltfStream();
importer->SetStream(gltf_stream);
importer->SetStreamURILoader(uri_loader);
importer->SetStreamIsBinary(false);
}
importer->Update();

Generally we ask Kitware to solve VTK upgrade problems, so that's over to +@BetsyMcPhail to delegate someone, please.

@jwnimmer-tri
Copy link
Collaborator

Oh. Pretty clearly the first place to start looking is this patch that deleted the error handling:
https://gitlab.kitware.com/vtk/vtk/-/commit/de1602836934a56f16f0d7d50ca2f23360aecebc#c641df96778e9d53adc770f010a0fa1f2d41a95a

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label May 6, 2025
@jwnimmer-tri
Copy link
Collaborator

(For the moment, it probably makes sense to add a *.patch file local to Drake that undoes the change to IO/Import/vtkGLTFImporter.cxx while you sort it out upstream. That will let us get this upgrade landed.)

@jwnimmer-tri
Copy link
Collaborator

@BetsyMcPhail this is also available as a small task for Kitware. Doesn't need to be a VTK-specific person.

@Aiden2244
Copy link
Contributor Author

Replaced by #23038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features)
Development

Successfully merging this pull request may close these issues.

3 participants