Skip to content

fix test to expect not feasible when data is not ready

50491d9
Select commit
Loading
Failed to load commit list.
Open

feat(traffic_light_filter): add support for amber light #12076

fix test to expect not feasible when data is not ready
50491d9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) succeeded Feb 26, 2026 in 39s

CodeScene PR Check

Quality Gate Passed

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
traffic_light_filter.cpp 8.82 → 9.10 Complex Conditional

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

✅ Improving Code Health:

  • Complex Conditional traffic_light_filter.cpp: TrafficLightFilter::get_red_stop_lines

Annotations

Check notice on line 86 in planning/autoware_trajectory_traffic_rule_filter/src/filters/traffic_light_filter.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

✅ No longer an issue: Complex Conditional

TrafficLightFilter::get_red_stop_lines no longer has a complex conditional. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.