feat(map_based_prediction): apply the custom find-nearest function#12128
Merged
ktro2828 merged 3 commits intoautowarefoundation:mainfrom Feb 25, 2026
Merged
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
approved these changes
Feb 24, 2026
YoshiRi
requested changes
Feb 24, 2026
Contributor
YoshiRi
left a comment
There was a problem hiding this comment.
LGTM but could you add some comments?
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
aba121b to
17380db
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12128 +/- ##
==========================================
+ Coverage 18.11% 18.61% +0.50%
==========================================
Files 1841 1872 +31
Lines 126643 127654 +1011
Branches 44419 46807 +2388
==========================================
+ Hits 22941 23764 +823
- Misses 84592 85340 +748
+ Partials 19110 18550 -560
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktro2828
added a commit
to tier4/autoware_universe
that referenced
this pull request
Feb 26, 2026
…utowarefoundation#12128) * feat: apply the custom find-nearest function Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> * chore: update comment Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp> --------- Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because the builtin lanelet2::findNearest(...) function doesn't consider the 3D spaces, it tend to take a longer time and consume higher computational costs in the case that lanelet has 3D dimensional overlaps.
In autowarefoundation/autoware_core#839, the custom fined nearest function is added.
Key changes:
Lanelet type updates for const-correctness:
lanelet::Lanelettolanelet::ConstLaneletin both header (utils.hpp) and implementation (utils.cpp) files, including incalculateLocalLikelihoodandcheckCloseLaneletCondition. [1] [2] [3]Nearest lanelet search improvements:
lanelet::geometry::findNearestwithexperimental::lanelet2_utils::find_nearestfor finding surrounding lanelets, which now returnsConstLaneletpairs.Const removal where mutable lanelets are needed:
experimental::lanelet2_utils::remove_constto convertConstLaneletto a mutableLaneletwhere necessary for downstream processing. [1] [2]Include updates:
autoware/lanelet2_utils/nn_search.hppheader to provide the new nearest neighbor search functionality.Related links
Private Links:
How was this PR tested?
Checkout
autoware_coretoktro2828:feat/lanelet2_utils/find_nearestand build:The following view shows the prediction visualization comparison (left: before, right: after).
Although the previous results are flicking due to high latency, the updated results are stable.
Screencast.from.2026.02.18.18.09.39.webm
The following figure shows the performance profile comparison:
Notes for reviewers
THIS PR MUST BE MERGED AFTER autowarefoundation/autoware_core#839 HAS DONE!!
Interface changes
None.
Effects on system behavior
None.