feat(trajectory_validator): combine validator and concatenator #12532
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(1 new file with code health below 9.00)
(1 file with Bumpy Road Ahead, Deep, Nested Complexity)
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| New code is healthy | Violations | Code Health Impact | |
|---|---|---|---|
| validation_stage.cpp | 3 rules | 8.96 | Suppress |
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| validation_stage.cpp | 2 critical rules | 8.96 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| validation_stage.cpp | 1 advisory rule | 8.96 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| trajectory_validator_node.cpp | 7.93 → 9.39 | Complex Method, Bumpy Road Ahead, Overall Code Complexity, Deep, Nested Complexity |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Deep, Nested Complexity validation_stage.cpp: ValidationStage::process
- Complex Method validation_stage.cpp: ValidationStage::process
- Bumpy Road Ahead validation_stage.cpp: ValidationStage::process
✅ Improving Code Health:
- Complex Method trajectory_validator_node.cpp: TrajectoryValidator::publish_plugins_report_text
- Complex Method trajectory_validator_node.cpp: TrajectoryValidator::process
- Bumpy Road Ahead trajectory_validator_node.cpp: TrajectoryValidator::process
- Overall Code Complexity trajectory_validator_node.cpp
- Deep, Nested Complexity trajectory_validator_node.cpp: TrajectoryValidator::process
- Deep, Nested Complexity trajectory_validator_node.cpp: TrajectoryValidator::publish_plugins_report_text
Annotations
Check notice on line 325 in planning/autoware_trajectory_validator/src/trajectory_validator_node.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Complex Method
TrajectoryValidator::publish_plugins_report_text decreases in cyclomatic complexity from 10 to 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 195 in planning/autoware_trajectory_validator/src/trajectory_validator_node.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Complex Method
TrajectoryValidator::process is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 195 in planning/autoware_trajectory_validator/src/trajectory_validator_node.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Bumpy Road Ahead
TrajectoryValidator::process is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/autoware_trajectory_validator/src/trajectory_validator_node.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Overall Code Complexity
The mean cyclomatic complexity in this module is no longer above the threshold
Check notice on line 195 in planning/autoware_trajectory_validator/src/trajectory_validator_node.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Deep, Nested Complexity
TrajectoryValidator::process is no longer above the threshold for nested complexity depth
Check notice on line 325 in planning/autoware_trajectory_validator/src/trajectory_validator_node.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Deep, Nested Complexity
TrajectoryValidator::publish_plugins_report_text is no longer above the threshold for nested complexity depth
Check warning on line 116 in planning/autoware_trajectory_validator/src/validation_stage.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
ValidationStage::process has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 116 in planning/autoware_trajectory_validator/src/validation_stage.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
ValidationStage::process has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 116 in planning/autoware_trajectory_validator/src/validation_stage.cpp
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Deep, Nested Complexity
ValidationStage::process has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.