Skip to content

feat(trajectory_validator): combine validator and concatenator#12532

Open
zulfaqar-azmi-t4 wants to merge 5 commits intoautowarefoundation:mainfrom
zulfaqar-azmi-t4:combine_validator_and_concatenator
Open

feat(trajectory_validator): combine validator and concatenator#12532
zulfaqar-azmi-t4 wants to merge 5 commits intoautowarefoundation:mainfrom
zulfaqar-azmi-t4:combine_validator_and_concatenator

Conversation

@zulfaqar-azmi-t4
Copy link
Copy Markdown
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented May 1, 2026

Description

As part of the effort to reduce the number of running nodes, this PR merges the trajectory concatenator functionality into the Trajectory Validator.

The concatenator is refactored into a pure C++ library (autoware::trajectory_concatenator::TrajectoryConcatenator) — independent of rclcpp — and is consumed by the Validator as the first stage of its multi-stage pipeline. The standalone concatenator node, its launch file, and its config yaml are removed; the concatenator parameters are now declared by the Validator node.

Related links

None

How was this PR tested?

Run PSIM with diffusion planner

Notes for reviewers

None.

Interface changes

  • removed trajectory_concatenatory.launch.xml and trajectory_concatenator.param.yaml

Effects on system behavior

  • One fewer process/node in the planning pipeline. The concatenation stage now runs in-process inside the Trajectory Validator, eliminating one inter-process hop and the associated serialization/transport overhead.
  • The concatenator stage's output cadence is unchanged: it is still flushed by a fixed-rate timer (the same ~30ms cadence noted in the new trajectory_concatenator.hpp), so the average / max latency floor of the stage itself is the same.
  • No semantic behavior change is expected: the concatenation logic (most-recent-per-generator buffer with time-based stale pruning) is identical to the previous standalone node; only its hosting process has changed.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions Bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 1, 2026
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 changed the title Combine validator and concatenator feat(trajectory_validator): combine validator and concatenator May 11, 2026
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review May 11, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:planning Route planning, decision-making, and navigation. (auto-assigned)

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

1 participant