feat(trajectory_validator): combine validator and concatenator#12532
Open
zulfaqar-azmi-t4 wants to merge 5 commits intoautowarefoundation:mainfrom
Open
feat(trajectory_validator): combine validator and concatenator#12532zulfaqar-azmi-t4 wants to merge 5 commits intoautowarefoundation:mainfrom
zulfaqar-azmi-t4 wants to merge 5 commits intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of the effort to reduce the number of running nodes, this PR merges the trajectory concatenator functionality into the Trajectory Validator.
The concatenator is refactored into a pure C++ library (
autoware::trajectory_concatenator::TrajectoryConcatenator) — independent ofrclcpp— and is consumed by the Validator as the first stage of its multi-stage pipeline. The standalone concatenator node, its launch file, and its config yaml are removed; the concatenator parameters are now declared by the Validator node.Related links
None
How was this PR tested?
Run PSIM with diffusion planner
Notes for reviewers
None.
Interface changes
trajectory_concatenatory.launch.xmlandtrajectory_concatenator.param.yamlEffects on system behavior
trajectory_concatenator.hpp), so the average / max latency floor of the stage itself is the same.