Skip to content

Feature/4ws model for mpc #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: release/2023.04
Choose a base branch
from

Conversation

lixianqiang
Copy link

Description

Add new vehicle model called four wheel steering model for mpc algorithm

Related links

Tests performed

Due to different vehicle models having varying minimum turning radii, typically, four-wheel steering models have a smaller turning radius compared to front-wheel steering models. A corresponding map is created based on the minimum turning radius of the current four-wheel steering model to test the performance of both models on that map. Based on the expected results, the four-wheel steering vehicles are expected to pass the test smoothly on that map, while the front-wheel steering vehicles may face difficulties passing the test or may not perform as well.

Notes for reviewers

i hope to new branhc called feature/4ws for four wheel steering model. so that enable collaboration with other developers

Interface changes

To add the optional parameter "kinematics_4ws_no_delay" to the "vehicle_model_type" in the "mpc_lateral_controller" file

Effects on system behavior

I have provided a new vehicle model to the system.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • [] There are no open discussions or they are tracked via tickets.
  • [] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

if you want to use 4ws model for mpc, please modify file mpc.param.yaml
which locale in autoware_launch module, beause the param is loaded from
there, it's content is same as lateral_controller_defaults.param.yaml
add an option ‘IDEAL_STEER_VEL_FOR_4WS’ for source code and some cpp file for model. if you want run it successfully, please modify simulator_model.param.yaml which locale in pixkit_launch/pixkit_description/config, there is ‘vehicle_model_type’ option and fill in as IDEAL_STEER_VEL_FOR_4WS, because the param loaded from there
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Jun 12, 2023
@stale
Copy link

stale bot commented Aug 11, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Aug 11, 2023
@shaoniandujianyiqingqiu
Copy link

Hello, if the vehicle control model uses four-wheel mode, will it affect the accuracy of positioning?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Mar 2, 2024
@ahuazuipiaoliang
Copy link
Member

@shaoniandujianyiqingqiu yes, the EKF localizer considers that the vehicle has no slip angle(beta) at base_link, which mean vy=0.
The reference point(base_link) of 4ws model is at the center of the vehicle, when the vehicle is on front steering model, there is a slip angle(beta) at the base_link point.
image

Copy link

stale bot commented May 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants