Skip to content

refactor(behavior_path_planner): rework parameters #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

batuhanbeytekin
Copy link
Member

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@batuhanbeytekin batuhanbeytekin added DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jul 16, 2024
@batuhanbeytekin batuhanbeytekin self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.10%. Comparing base (bda8706) to head (5c5b286).
Report is 414 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8064      +/-   ##
==========================================
- Coverage   24.10%   24.10%   -0.01%     
==========================================
  Files        1399     1406       +7     
  Lines      102337   103068     +731     
  Branches    38870    38883      +13     
==========================================
+ Hits        24668    24842     +174     
- Misses      75141    75755     +614     
+ Partials     2528     2471      -57     
Flag Coverage Δ *Carryforward flag
differential 14.64% <ø> (?)
total 24.11% <ø> (+0.01%) ⬆️ Carriedforward from 441bfcf

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@batuhanbeytekin batuhanbeytekin marked this pull request as draft July 17, 2024 12:19
@batuhanbeytekin batuhanbeytekin force-pushed the refactor/behavior_path_planner branch from 6b73632 to 5c5b286 Compare August 28, 2024 11:06
Copy link

stale bot commented Oct 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant