-
Notifications
You must be signed in to change notification settings - Fork 1
feat(core): add action binder for source and perspective #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cngonzalez
merged 1 commit into
main
from
01-29-feat_core_add_action_binder_for_source_and_perspective
Feb 3, 2026
Merged
feat(core): add action binder for source and perspective #724
cngonzalez
merged 1 commit into
main
from
01-29-feat_core_add_action_binder_for_source_and_perspective
Feb 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jan 29, 2026
Member
Author
cngonzalez
commented
Jan 29, 2026
| const sourceKey = createSourceKey(instance, source) | ||
|
|
||
| return { | ||
| name: `${sourceKey.name}:${perspectiveKey}`, |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming is only here to ensure uniqueness among stores -- resources will read perspective from the key rather than this string.
3b1698d to
fffce17
Compare
8677c7e to
4655bb1
Compare
This was referenced Jan 30, 2026
Base automatically changed from
01-26-fix_query_use_store_key_to_determine_client_for_live_events
to
main
February 3, 2026 18:34
4655bb1 to
a5da929
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
binoy14
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

FIXES SDK-743
Description
This PR is prep for #723, so the changes here aren't actually used anywhere.
It exists because stores like the projection store need to be separated out by perspective. This is because:
I also had to move
isReleasePerspectiveto its own utility file because of import dependency cycles which someone definitely warned me about in a previous PR.What to review
Hopefully this is pretty straightforward, nothing in particular I'm super worried about.
Testing
Tests were added for the new utilities.