-
Notifications
You must be signed in to change notification settings - Fork 1
feat(document): update document store to accept sources #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cngonzalez
wants to merge
1
commit into
main
Choose a base branch
from
02-03-feat_document_update_document_store_to_accept_sources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(document): update document store to accept sources #730
cngonzalez
wants to merge
1
commit into
main
from
02-03-feat_document_update_document_store_to_accept_sources
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Feb 3, 2026
Member
Author
3da69ef to
ecb1bad
Compare
8118fef to
414b5c2
Compare
ecb1bad to
2fc0f75
Compare
414b5c2 to
5a03ef1
Compare
2fc0f75 to
fe62d9c
Compare
fe62d9c to
6e66fe0
Compare
5a03ef1 to
1ee130b
Compare
6e66fe0 to
14b1f0b
Compare
1ee130b to
b4a3333
Compare
14b1f0b to
a1a8e01
Compare
a1a8e01 to
ef129f0
Compare
b4a3333 to
29026a9
Compare
29026a9 to
18535b3
Compare
ef129f0 to
07d8fea
Compare
18535b3 to
cd6689d
Compare
07d8fea to
f687768
Compare
This was referenced Feb 6, 2026
f687768 to
e80329b
Compare
cd6689d to
d3d556f
Compare
e80329b to
64c35c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

FIXES SDK-750
Description
This PR refactors document actions to use a
sourceparameter, as we're doing for other stores.Changes in core SDK:
This mostly involves updating the core document store to have a "source" key, using
bindActionBySourceinstead ofbindActionByDatasetand updating actions (likeapplyDocumentActions) to match the signature required bybindActionBy Source.Changes in React SDK:
In the React package, changes were made to be able to get a source outside of a hook (like in the
applyDocumentActionsfunction body) and to ensure source was passed along to the relevant functions.Changes in Kitchensink:

Kitchensink was updated to abstract out the
JsonDocumentEditorso we have an easy implementation of updating Media Library documents.What to review
The biggest change here is that some supplementary functions like
applyDocumentActionshave a requiredsourceparameter. This isn't different from other functions where we use this helper, but is a bit of a mental shift. I think it tracks with "source is always required in core" (since we no longer want to rely on the instance to provide projectId/dataset) but it's what I'm looking for the most feedback for.Testing
Updated tests to ensure sufficient coverage and matching the new signature. e2e tests seem necessary but will be done in an upcoming PR.
Fun gif