feat(projection): update projection store to use source and perspective #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jan 29, 2026
Member
Author
cngonzalez
commented
Jan 29, 2026
| expect(Object.keys(params)).toHaveLength(1) | ||
| expect(params[`__ids_${projectionHash}`]).toBeDefined() | ||
| expect(params[`__ids_${projectionHash}`]).toHaveLength(4) | ||
| expect(params[`__ids_${projectionHash}`]).toHaveLength(2) |
Member
Author
There was a problem hiding this comment.
Two because we are no longer querying for drafts and published versions of each document ID.
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
bc18070 to
45393e1
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
45393e1 to
844eb05
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
844eb05 to
84bbc5d
Compare
cngonzalez
changed the base branch from
01-26-fix_query_use_store_key_to_determine_client_for_live_events
to
graphite-base/723
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
84bbc5d to
1e7d4e5
Compare
cngonzalez
changed the base branch from
graphite-base/723
to
01-29-feat_core_add_action_binder_for_source_and_perspective
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
1e7d4e5 to
01569a5
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
01569a5 to
b3a3482
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
2f4fde3 to
6e266b1
Compare
cngonzalez
changed the base branch from
graphite-base/723
to
make-signin-tests-more-lenient
cngonzalez
force-pushed
the
make-signin-tests-more-lenient
branch
from
c5d5f98 to
caf89f8
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
6e266b1 to
1352f30
Compare
cngonzalez
changed the title
cngonzalez
changed the base branch from
make-signin-tests-more-lenient
to
graphite-base/723
cngonzalez
force-pushed
the
graphite-base/723
branch
from
caf89f8 to
bb1eac4
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
1352f30 to
97d6f8b
Compare
cngonzalez
force-pushed
the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
from
97d6f8b to
6845df6
Compare
This was referenced Feb 5, 2026
binoy14
approved these changes
Feb 6, 2026
Contributor
binoy14
left a comment
binoy14
left a comment
There was a problem hiding this comment.
Not 100% sure what's going on but nothing stands out
Member
Author
Merge activity
|
cngonzalez
deleted the
01-28-refactor_projection_update_projection_store_to_use_source_and_perspective
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES SDK-546
FIXES SDK-739
Description
Projections never worked particularly well with perspectives because they used the "raw" perspective and manually overlaid a draft version over a published version. This isn't necessary with perspectives, so that functionality is added. It's also required for projections that do joins via references -- "raw" won't properly resolve draft versions of referenced documents.
I've also used the opportunity to migrate projections to sources as well as perspectives, so you'll see some new action binders here.
To avoid a breaking change, there were some changes to the "status" query. I considered omitting it and leaving this to be a breaking change, but the status allows us to maintain parity with what Studio does (see screenshot)
What to review
I'm most concerned about the status query stuff.
Testing
Added tests for new functions and updating existing ones where required. E2E tests are coming in a following PR. I can't get the Webkit E2E test to work, but it's failing on "unauthenticated" because of a cookie dialogue, so that needs to be fixed separately.
You can also ref the old behavior here (note that the reference is "published" and the value doesn't change when we change perspectives):
Against the new behavior here:
Fun gif