-
Notifications
You must be signed in to change notification settings - Fork 1
feat(preview): update preview to use perspective and source #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cngonzalez
wants to merge
2
commits into
02-03-feat_document_update_document_store_to_accept_sources
Choose a base branch
from
02-05-feat_preview_update_preview_to_use_perspective_and_source
base: 02-03-feat_document_update_document_store_to_accept_sources
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Feb 5, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
6119f73 to
0b6ff40
Compare
0b6ff40 to
d13a510
Compare
d13a510 to
54d385d
Compare
14b1f0b to
a1a8e01
Compare
54d385d to
cfb3ce5
Compare
cfb3ce5 to
9c747ff
Compare
a1a8e01 to
ef129f0
Compare
9c747ff to
3d3f433
Compare
ef129f0 to
07d8fea
Compare
3d3f433 to
004635a
Compare
004635a to
f2dd8c8
Compare
07d8fea to
f687768
Compare
This was referenced Feb 6, 2026
e80329b to
64c35c1
Compare
f2dd8c8 to
d32d02a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
As we convert things to sources, we can also get rid of some complexity. There wasn't much sense in having separate preview and projection stores, at least without access to schemas. The projection store has batched querying and status coalescing and everything else we need in previews.
This PR removes the preview store and leaves some deprecated functions that pass through to the projection store to maintain backwards compatibility. The React hook uses
useDocumentProjectiondirectly, which means we can remove the deprecated functions in v3.Some helpers were moved around and updated to prepare for this as well.
What to review
previewProjectionUtils.tsuseDocumentPreviewhook implementationTesting
Added comprehensive unit tests for:
transformProjectionToPreviewutilitygetPreviewStatefunctionresolvePreviewfunctionuseDocumentPreviewhookAlso updated e2e tests in the kitchensink app to verify that preview results are displayed correctly and update in real-time when document content changes.
Fun gif
FIXES SDK-761