fix(random_test_runner): remove workaround, fixed in https://github.c…#1604
fix(random_test_runner): remove workaround, fixed in https://github.c…#1604esteve wants to merge 1 commit intotier4:masterfrom
Conversation
|
Do not merge until ros2/tinyxml2_vendor#23 is merged and backported to Humble |
|
@esteve |
HansRobo
added
the
bump patch
HansRobo
requested review from
HansRobo,
hakuturu583,
shouth,
takanotaiga and
yamacir-kit
as code owners
|
Now, ros2/tinyxml2_vendor#23 was already merged. |
esteve
force-pushed
the
remove-tinxyml2-workaround
branch
from
b10f098 to
92814c3
Compare
|
Oh, the CIs are failed. |
|
@HansRobo it's only available for rolling, I'll submit PRs to humble, jazzy and humble |
|
@HansRobo I've submitted the following PRs backporting the fix for Humble (ros2/tinyxml2_vendor#27), Jazzy (ros2/tinyxml2_vendor#28) and Kilted (ros2/tinyxml2_vendor#29) |
|
@esteve Thank you very much! |
esteve
force-pushed
the
remove-tinxyml2-workaround
branch
2 times, most recently
from
1694a2d to
c6007ec
Compare
|
@HansRobo ros2/tinyxml2_vendor#27 and ros2/tinyxml2_vendor#28 are merged and released, this PR can be merged now |
esteve
force-pushed
the
remove-tinxyml2-workaround
branch
from
0a61f43 to
9d12d7f
Compare
|
Hmm, perhaps ros2/tinyxml2_vendor#27 wasn't enough. |
…ndor#23 Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
mitsudome-r
force-pushed
the
remove-tinxyml2-workaround
branch
from
9d12d7f to
3d1e8ce
Compare
2 participants
Description
This PR removes the workaround for autowarefoundation/autoware_universe#10410
Abstract
The
tinyxml2_vendorpackage is unable to find the TinyXML2 library, potential fix can be found at ros2/tinyxml2_vendor#23