host: include mdadm RAID devices in disk detection#447
Merged
Conversation
cfc6b2d to
88817d6
Compare
| ( | ||
| disk | ||
| for disk in self.block_devices_info | ||
| if (not disk["pkname"] or disk['type'] == 'raid0') and disk['kname'] not in pknames |
Contributor
There was a problem hiding this comment.
Suggestion: Maybe in the future, it could be great to implement a class BlockDevice with appropriates methods to enhance readability and intent. eg:
my_block = BlockDevice()
my_block.has_children()
my_block.is_raid()
Member
Author
There was a problem hiding this comment.
100% agree, we should make that cleaner, but this one works with only a few changes, so I'll keep it for another PR if you don't mind :)
88817d6 to
ea4bbd2
Compare
This was referenced Mar 31, 2026
a11ecb2 to
9b0818e
Compare
ea4bbd2 to
1ca167d
Compare
9b0818e to
5800d41
Compare
1ca167d to
0d5b7e0
Compare
5800d41 to
a6a78f3
Compare
5a70972 to
aefdeee
Compare
a6a78f3 to
0f07c9b
Compare
0f07c9b to
f9ef7d9
Compare
36e3f27 to
c087f3f
Compare
f9ef7d9 to
b6785fe
Compare
stormi
approved these changes
Apr 8, 2026
Member
stormi
left a comment
There was a problem hiding this comment.
I would appreciate a commit message which conforms to https://docs.xcp-ng.org/project/development-process/commit-message-conventions/
Commit messages must always describe the problem they solve.
I'll approve anyway given the size of the commit.
b6785fe to
942d050
Compare
rzr
approved these changes
Apr 13, 2026
f4248cf to
eb0eac0
Compare
55afccc to
391e5c2
Compare
eb0eac0 to
9ade0b0
Compare
89f4a1e to
caa6494
Compare
a63e581 to
d7826f6
Compare
68e4d09 to
3030f33
Compare
d7826f6 to
a29798c
Compare
This was referenced Apr 24, 2026
3030f33 to
1b5757b
Compare
a29798c to
9d399c6
Compare
Detect RAID devices and exclude child devices to properly enumerate all available disks including software RAID arrays. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
1b5757b to
5b525a6
Compare
Millefeuille42
approved these changes
May 12, 2026
Lankou66
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a tree containing 19 PRs:
mastermaster