Skip to content

storage: test full device write - #453

Merged
Lankou66 merged 1 commit into
masterfrom
gln/storage-full-device-write-test-lnxw
May 12, 2026
Merged

storage: test full device write#453
Lankou66 merged 1 commit into
masterfrom
gln/storage-full-device-write-test-lnxw

Conversation

@glehmann

@glehmann glehmann commented Mar 31, 2026

Copy link
Copy Markdown
Member

With most test now writing only a small amount of data to the devices,
we need these new test to validate that we can write on the whole
device.

This PR is part of a tree containing 19 PRs:

  1. master
  2. storage: avoid removing the xva/vdi before going in the debugger #436master
  3. storage: test large volumes #437storage: avoid removing the xva/vdi before going in the debugger #436
  4. host: include mdadm RAID devices in disk detection #447storage: test large volumes #437
  5. Update randstream to 0.5.0 #446host: include mdadm RAID devices in disk detection #447
  6. storage: Avoid writing the whole device in coalesce tests #449Update randstream to 0.5.0 #446
  7. storage: avoid writing the whole device in migration tests #450storage: Avoid writing the whole device in coalesce tests #449
  8. xva/vdi: only write a small data amount in large volumes for faster tests #452storage: avoid writing the whole device in migration tests #450
  9. "storage: test full device write" (this PR) → xva/vdi: only write a small data amount in large volumes for faster tests #452
  10. storage: test that we can't create a vdi over its max allowed size #454storage: test full device write #453
  11. storage: add jobs for large volume tests #461storage: test that we can't create a vdi over its max allowed size #454
  12. skip large volume tests for zvol and nfsv4 #464storage: add jobs for large volume tests #461
  13. storage: add comprehensive tests for lvmohba storage repositories #470skip large volume tests for zvol and nfsv4 #464
  14. storage: free space for XVA import by destroying source VM first #471storage: add comprehensive tests for lvmohba storage repositories #470
  15. storage: limit data written per VDI with --write-volume-cap #481storage: free space for XVA import by destroying source VM first #471
  16. Add Packer configuration to build a minimal Alpine 3.23 UEFI VM for XCP-ng tests #523storage: limit data written per VDI with --write-volume-cap #481
  17. migration: create a xfs sr on the second host for intra/cross-pool migration #497storage: limit data written per VDI with --write-volume-cap #481
  18. Enhance block device management #498migration: create a xfs sr on the second host for intra/cross-pool migration #497
  19. Add VHD_MAX and QCOW2_MAX symbolic size constants #500Enhance block device management #498
  20. partially_populate_device: align span positions to block size for better performance #509Add VHD_MAX and QCOW2_MAX symbolic size constants #500

@glehmann
glehmann requested review from a team as code owners March 31, 2026 18:17
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from e8f5283 to da6833e Compare March 31, 2026 18:27
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from 1c6e3f6 to 7c2f3e2 Compare March 31, 2026 18:27
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from 7c2f3e2 to c822443 Compare March 31, 2026 20:33
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from da6833e to aaa0313 Compare March 31, 2026 20:33
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from c822443 to f417ebe Compare March 31, 2026 20:36
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from aaa0313 to 45ae839 Compare March 31, 2026 20:36
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 45ae839 to 4d86583 Compare April 7, 2026 13:20
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from 1a17484 to fb79a42 Compare April 7, 2026 13:32
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 4d86583 to 51c7f71 Compare April 7, 2026 13:32
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 51c7f71 to a114b87 Compare April 8, 2026 20:28
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch 2 times, most recently from 81016ba to e2e40fb Compare April 8, 2026 21:22
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from a114b87 to d73f62d Compare April 8, 2026 21:22
@stormi

stormi commented Apr 8, 2026

Copy link
Copy Markdown
Member

With most test now writing only a small amount of data to the devices,
we need these new test to validate that we can write on the whole
device.

It's good to tell us in the PR, but the commit message also should tell that. Oops, it does. Looks like I don't know how to use GH at this time of the day.

):
vdi_export_import(storage_test_vm, ext_sr, image_format, temp_large_dir, defer)

@pytest.mark.small_vm

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back when I created small_vm, I also created big_vm, indicating that we should also run the same test with a big VM (but we never actually used that in jobs) and multi_vm for tests that should run on a variety of VMs.

It's not exactly appropriate anymore, since these storage tests start from a small VM and grow it to the required sizee now, but the naming became confusing. We'll have to think about its evolution at some point.

@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from d73f62d to be4d623 Compare April 9, 2026 05:39
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch 2 times, most recently from 5259524 to fcee475 Compare April 13, 2026 08:20
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from a681188 to e7eefce Compare April 13, 2026 08:20
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from e7eefce to a2e8407 Compare April 15, 2026 16:18
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from fcee475 to 9b1e681 Compare April 15, 2026 16:18
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from a2e8407 to 55abfdd Compare April 16, 2026 18:00
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 9b1e681 to 53c84c9 Compare April 16, 2026 18:00
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from 55abfdd to e0685a0 Compare April 17, 2026 13:52
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 53c84c9 to a58f4e1 Compare April 17, 2026 13:52
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from e0685a0 to 11acfa7 Compare April 21, 2026 06:08
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from a58f4e1 to 0337957 Compare April 21, 2026 06:08
@glehmann
glehmann force-pushed the gln/optimize-test-volume-writes-qxtl branch from 11acfa7 to dffb856 Compare April 24, 2026 14:56
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 0337957 to bbc37bb Compare April 24, 2026 14:57
With most test now writing only a small amount of data to the devices,
we need this new test to validate that we can write on the whole
device.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 8296fdc to caadb1e Compare May 11, 2026 15:48
Base automatically changed from gln/optimize-test-volume-writes-qxtl to master May 12, 2026 12:59
@Lankou66
Lankou66 merged commit 59514b3 into master May 12, 2026
9 checks passed
@Lankou66
Lankou66 deleted the gln/storage-full-device-write-test-lnxw branch May 12, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants