Skip to content

Add VHD_MAX and QCOW2_MAX symbolic size constants - #500

Merged
glehmann merged 1 commit into
masterfrom
gln/add-max-volume-size-constants-npxp
Jun 2, 2026
Merged

Add VHD_MAX and QCOW2_MAX symbolic size constants#500
glehmann merged 1 commit into
masterfrom
gln/add-max-volume-size-constants-npxp

Conversation

@glehmann

@glehmann glehmann commented Apr 24, 2026

Copy link
Copy Markdown
Member

Allow passing VHD_MAX and QCOW2_MAX as values to --volume-size and
--write-volume-cap, making it easy to test at the maximum supported VDI
size for each image format. MAX_VDI_SIZE in storage.py is now derived
from the same constants to keep a single source of truth.

Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech

This PR is part of a tree containing 19 PRs:

  1. master
  2. storage: avoid removing the xva/vdi before going in the debugger #436master
  3. storage: test large volumes #437storage: avoid removing the xva/vdi before going in the debugger #436
  4. host: include mdadm RAID devices in disk detection #447storage: test large volumes #437
  5. Update randstream to 0.5.0 #446host: include mdadm RAID devices in disk detection #447
  6. storage: Avoid writing the whole device in coalesce tests #449Update randstream to 0.5.0 #446
  7. storage: avoid writing the whole device in migration tests #450storage: Avoid writing the whole device in coalesce tests #449
  8. xva/vdi: only write a small data amount in large volumes for faster tests #452storage: avoid writing the whole device in migration tests #450
  9. storage: test full device write #453xva/vdi: only write a small data amount in large volumes for faster tests #452
  10. storage: test that we can't create a vdi over its max allowed size #454storage: test full device write #453
  11. storage: add jobs for large volume tests #461storage: test that we can't create a vdi over its max allowed size #454
  12. skip large volume tests for zvol and nfsv4 #464storage: add jobs for large volume tests #461
  13. storage: add comprehensive tests for lvmohba storage repositories #470skip large volume tests for zvol and nfsv4 #464
  14. storage: free space for XVA import by destroying source VM first #471storage: add comprehensive tests for lvmohba storage repositories #470
  15. storage: limit data written per VDI with --write-volume-cap #481storage: free space for XVA import by destroying source VM first #471
  16. Add Packer configuration to build a minimal Alpine 3.23 UEFI VM for XCP-ng tests #523storage: limit data written per VDI with --write-volume-cap #481
  17. migration: create a xfs sr on the second host for intra/cross-pool migration #497storage: limit data written per VDI with --write-volume-cap #481
  18. Enhance block device management #498migration: create a xfs sr on the second host for intra/cross-pool migration #497
  19. "Add VHD_MAX and QCOW2_MAX symbolic size constants" (this PR) → Enhance block device management #498
  20. partially_populate_device: align span positions to block size for better performance #509Add VHD_MAX and QCOW2_MAX symbolic size constants #500

@glehmann
glehmann requested review from a team as code owners April 24, 2026 20:12
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from 1168197 to f101a3f Compare April 24, 2026 20:35
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch 3 times, most recently from a6948a5 to 0a82603 Compare April 29, 2026 17:38
@glehmann
glehmann requested a review from a team as a code owner April 29, 2026 17:38
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from f101a3f to ede9108 Compare April 29, 2026 17:38
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from 0a82603 to b73bcc9 Compare May 11, 2026 15:48
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch 2 times, most recently from 5df0dc2 to ff50780 Compare May 12, 2026 13:23
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from 1960a93 to 8f39146 Compare May 12, 2026 13:23
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch 2 times, most recently from c70e171 to fbb8227 Compare May 13, 2026 13:58
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch 2 times, most recently from 9f88dc5 to 7cc39d2 Compare May 18, 2026 16:22
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from fbb8227 to 3e8fe23 Compare May 18, 2026 16:22
@stormi
stormi removed the request for review from a team May 18, 2026 17:18
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from 3e8fe23 to 44d95e4 Compare May 19, 2026 15:29
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch 2 times, most recently from 3845b8f to 8b8e409 Compare May 19, 2026 15:55
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from 44d95e4 to c097695 Compare May 19, 2026 15:55
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from 8b8e409 to 88a80e1 Compare May 20, 2026 19:02
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from c097695 to 937fa6d Compare May 20, 2026 19:02
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from 88a80e1 to ce5225e Compare May 21, 2026 13:43
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from 937fa6d to 27533d0 Compare May 21, 2026 13:43
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from ce5225e to e196d05 Compare May 21, 2026 14:07
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch 2 times, most recently from 2a7ce58 to 4ca7988 Compare May 21, 2026 14:16
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from e196d05 to 291e27e Compare May 21, 2026 14:16
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from 4ca7988 to ce36044 Compare May 21, 2026 14:29
@glehmann
glehmann force-pushed the gln/block-device-enhancement-and-lun-deduplication-rqtm branch from 1130de5 to dc44617 Compare May 22, 2026 15:29
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from ce36044 to ff961ea Compare May 22, 2026 15:29
Allow passing VHD_MAX and QCOW2_MAX as values to --volume-size and
--write-volume-cap, making it easy to test at the maximum supported VDI
size for each image format. MAX_VDI_SIZE in storage.py is now derived
from the same constants to keep a single source of truth.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann
glehmann force-pushed the gln/add-max-volume-size-constants-npxp branch from ff961ea to b882ed3 Compare May 29, 2026 11:37
Base automatically changed from gln/block-device-enhancement-and-lun-deduplication-rqtm to master May 29, 2026 12:32
@glehmann
glehmann merged commit 8b1c034 into master Jun 2, 2026
11 checks passed
@glehmann
glehmann deleted the gln/add-max-volume-size-constants-npxp branch June 2, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants