Skip to content

storage: test that we can't create a vdi over its max allowed size#454

Merged
Lankou66 merged 1 commit into
masterfrom
gln/test-vdi-size-limit-xnzn
May 12, 2026
Merged

storage: test that we can't create a vdi over its max allowed size#454
Lankou66 merged 1 commit into
masterfrom
gln/test-vdi-size-limit-xnzn

Conversation

@glehmann
Copy link
Copy Markdown
Member

@glehmann glehmann commented Mar 31, 2026

Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech

This PR is part of a tree containing 19 PRs:

  1. master
  2. storage: avoid removing the xva/vdi before going in the debugger #436master
  3. storage: test large volumes #437storage: avoid removing the xva/vdi before going in the debugger #436
  4. host: include mdadm RAID devices in disk detection #447storage: test large volumes #437
  5. Update randstream to 0.5.0 #446host: include mdadm RAID devices in disk detection #447
  6. storage: Avoid writing the whole device in coalesce tests #449Update randstream to 0.5.0 #446
  7. storage: avoid writing the whole device in migration tests #450storage: Avoid writing the whole device in coalesce tests #449
  8. xva/vdi: only write a small data amount in large volumes for faster tests #452storage: avoid writing the whole device in migration tests #450
  9. storage: test full device write #453xva/vdi: only write a small data amount in large volumes for faster tests #452
  10. "storage: test that we can't create a vdi over its max allowed size" (this PR) → storage: test full device write #453
  11. storage: add jobs for large volume tests #461storage: test that we can't create a vdi over its max allowed size #454
  12. skip large volume tests for zvol and nfsv4 #464storage: add jobs for large volume tests #461
  13. storage: add comprehensive tests for lvmohba storage repositories #470skip large volume tests for zvol and nfsv4 #464
  14. storage: free space for XVA import by destroying source VM first #471storage: add comprehensive tests for lvmohba storage repositories #470
  15. storage: limit data written per VDI with --write-volume-cap #481storage: free space for XVA import by destroying source VM first #471
  16. Add Packer configuration to build a minimal Alpine 3.23 UEFI VM for XCP-ng tests #523storage: limit data written per VDI with --write-volume-cap #481
  17. migration: create a xfs sr on the second host for intra/cross-pool migration #497storage: limit data written per VDI with --write-volume-cap #481
  18. Enhance block device management #498migration: create a xfs sr on the second host for intra/cross-pool migration #497
  19. Add VHD_MAX and QCOW2_MAX symbolic size constants #500Enhance block device management #498
  20. partially_populate_device: align span positions to block size for better performance #509Add VHD_MAX and QCOW2_MAX symbolic size constants #500

@glehmann glehmann requested review from a team as code owners March 31, 2026 20:26
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from e5fe7bb to f28fd21 Compare March 31, 2026 20:33
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from da6833e to aaa0313 Compare March 31, 2026 20:33
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from f28fd21 to 827ea5e Compare March 31, 2026 20:36
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from aaa0313 to 45ae839 Compare March 31, 2026 20:36
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from 827ea5e to fc7a557 Compare April 1, 2026 14:12
@glehmann glehmann changed the title storage: test that we can't create a vdi over 16TiB storage: test that we can't create a vdi over its max allowed size Apr 6, 2026
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from fc7a557 to 09c9a94 Compare April 7, 2026 05:54
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from 09c9a94 to 53fc802 Compare April 7, 2026 11:39
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 45ae839 to 4d86583 Compare April 7, 2026 13:20
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch 2 times, most recently from 4fe002d to 8045e7c Compare April 7, 2026 13:32
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 4d86583 to 51c7f71 Compare April 7, 2026 13:32
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from 8045e7c to fbd0973 Compare April 8, 2026 20:28
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch 2 times, most recently from a114b87 to d73f62d Compare April 8, 2026 21:22
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from fbd0973 to 1978ff7 Compare April 8, 2026 21:22
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 9b1e681 to 53c84c9 Compare April 16, 2026 18:00
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch 2 times, most recently from 90d2167 to d98d020 Compare April 17, 2026 13:52
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 53c84c9 to a58f4e1 Compare April 17, 2026 13:52
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from d98d020 to 7854115 Compare April 21, 2026 06:08
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from a58f4e1 to 0337957 Compare April 21, 2026 06:08

@pytest.mark.small_vm
@pytest.mark.xfail(reason="not implemented yet")
def test_invalid_vdi_size(self, zfsvol_sr: SR, image_format: ImageFormat):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zfsvol isn't a SMv1 driver so it doesn't respect the image_format parameter.
It also doesn't have a max size since it's allocating a zfs volume for each VDI, it will only be limited by the max volume size of ZFS.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why it's marked as xfail. Do you prefer to not have it at all?

@dinhngtu
Copy link
Copy Markdown
Member

dinhngtu commented Apr 28, 2026

Do you need a H&K review on this PR? Same to #447 and a few others I suppose

@glehmann glehmann removed the request for review from a team April 28, 2026 11:42
@glehmann
Copy link
Copy Markdown
Member Author

Do you need a H&K review on this PR? Same to #447 and a few others I suppose

I don't think we do. I'm not sure how H&K was added to the reviewers.
I'm removing it

Depending on the image format.

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
@glehmann glehmann force-pushed the gln/storage-full-device-write-test-lnxw branch from 8296fdc to caadb1e Compare May 11, 2026 15:48
@glehmann glehmann force-pushed the gln/test-vdi-size-limit-xnzn branch from 2ce8370 to 83daf10 Compare May 11, 2026 15:49
Base automatically changed from gln/storage-full-device-write-test-lnxw to master May 12, 2026 13:04
@Lankou66 Lankou66 merged commit 79e9c24 into master May 12, 2026
9 checks passed
@Lankou66 Lankou66 deleted the gln/test-vdi-size-limit-xnzn branch May 12, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants