storage: test that we can't create a vdi over its max allowed size - #454
Merged
Conversation
This was referenced Mar 31, 2026
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
March 31, 2026 20:33
e5fe7bb to
f28fd21
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
March 31, 2026 20:33
da6833e to
aaa0313
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
March 31, 2026 20:36
f28fd21 to
827ea5e
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
March 31, 2026 20:36
aaa0313 to
45ae839
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 1, 2026 14:12
827ea5e to
fc7a557
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 7, 2026 05:54
fc7a557 to
09c9a94
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 7, 2026 11:39
09c9a94 to
53fc802
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 7, 2026 13:20
45ae839 to
4d86583
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
2 times, most recently
from
April 7, 2026 13:32
4fe002d to
8045e7c
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 7, 2026 13:32
4d86583 to
51c7f71
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 8, 2026 20:28
8045e7c to
fbd0973
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
2 times, most recently
from
April 8, 2026 21:22
a114b87 to
d73f62d
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 8, 2026 21:22
fbd0973 to
1978ff7
Compare
stormi
approved these changes
Apr 8, 2026
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 16, 2026 18:00
9b1e681 to
53c84c9
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
2 times, most recently
from
April 17, 2026 13:52
90d2167 to
d98d020
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 17, 2026 13:52
53c84c9 to
a58f4e1
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 21, 2026 06:08
d98d020 to
7854115
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 21, 2026 06:08
a58f4e1 to
0337957
Compare
Nambrok
requested changes
Apr 22, 2026
|
|
||
| @pytest.mark.small_vm | ||
| @pytest.mark.xfail(reason="not implemented yet") | ||
| def test_invalid_vdi_size(self, zfsvol_sr: SR, image_format: ImageFormat): |
Contributor
There was a problem hiding this comment.
zfsvol isn't a SMv1 driver so it doesn't respect the image_format parameter.
It also doesn't have a max size since it's allocating a zfs volume for each VDI, it will only be limited by the max volume size of ZFS.
Member
Author
There was a problem hiding this comment.
That's why it's marked as xfail. Do you prefer to not have it at all?
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 24, 2026 14:55
7854115 to
1c26e91
Compare
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 24, 2026 14:57
0337957 to
bbc37bb
Compare
This was referenced Apr 24, 2026
Member
|
Do you need a H&K review on this PR? Same to #447 and a few others I suppose |
Member
Author
I don't think we do. I'm not sure how H&K was added to the reviewers. |
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
April 29, 2026 17:39
bbc37bb to
8296fdc
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
April 29, 2026 17:39
1c26e91 to
2ce8370
Compare
Depending on the image format. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/storage-full-device-write-test-lnxw
branch
from
May 11, 2026 15:48
8296fdc to
caadb1e
Compare
glehmann
force-pushed
the
gln/test-vdi-size-limit-xnzn
branch
from
May 11, 2026 15:49
2ce8370 to
83daf10
Compare
Base automatically changed from
gln/storage-full-device-write-test-lnxw
to
master
May 12, 2026 13:04
Millefeuille42
approved these changes
May 12, 2026
Lankou66
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a tree containing 19 PRs:
mastermaster