storage: limit data written per VDI with --write-volume-cap - #481
Merged
Conversation
This was referenced Apr 15, 2026
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 16, 2026 18:00
6ee5b4d to
fc1e701
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 16, 2026 18:00
81ce353 to
d273947
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 16, 2026 18:38
fc1e701 to
af6499e
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
2 times, most recently
from
April 17, 2026 13:52
f244985 to
e3515aa
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
3 times, most recently
from
April 21, 2026 06:08
6ddff5e to
ef998eb
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 21, 2026 06:08
e3515aa to
3806fe9
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 21, 2026 12:47
ef998eb to
2c3ab59
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 21, 2026 12:47
3806fe9 to
150f448
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 21, 2026 13:24
2c3ab59 to
261ee8d
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 21, 2026 13:24
150f448 to
067a161
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 21, 2026 14:03
261ee8d to
36f7634
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 21, 2026 14:03
067a161 to
352e955
Compare
rzr
reviewed
Apr 23, 2026
| ignore_ssh_banner = False | ||
| ssh_output_max_lines = 20 | ||
| volume_size = 1 * GiB | ||
| write_volume_cap = 2 * GiB |
rzr
reviewed
Apr 23, 2026
| if "NFS4" in dispatch_nfs.vdis[0].sr.get_name_label() and config.volume_size > 20 * GiB: | ||
| def test_xva_export_import(self, dispatch_nfs: VM, compression: XVACompression, temp_large_dir: str, | ||
| defer: Defer) -> None: | ||
| if "NFS4" in dispatch_nfs.vdis[0].sr.get_name_label() and config.write_volume_cap > 20 * GiB: |
Contributor
There was a problem hiding this comment.
Sorry if asked previously but why magic numbers are duplicated, and not a constant introduced?
Member
Author
There was a problem hiding this comment.
Because I didn't feel a need for it, I suppose.
Indeed, I think we've already had this discussion :)
rzr
reviewed
Apr 23, 2026
| integrity_check = not vm.is_windows | ||
| dev = "" | ||
| checksums = ('', '', '') | ||
| spans: list[StreamSpan] = [] |
Contributor
There was a problem hiding this comment.
What about using sets in place of list ?
Member
Author
There was a problem hiding this comment.
That's the type returned by the function that creates them.
And it's convenient to use a list as return type because they are not all equivalent when using skip_span.
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 24, 2026 14:55
352e955 to
9facd7c
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 24, 2026 14:55
36f7634 to
6467349
Compare
This was referenced Apr 24, 2026
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
April 29, 2026 17:38
9facd7c to
ce6bf19
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
April 29, 2026 17:38
6467349 to
dbae6f8
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
May 11, 2026 15:48
dbae6f8 to
e9ab3bf
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
May 12, 2026 13:16
e9ab3bf to
f2fef78
Compare
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
May 12, 2026 13:16
b2f50eb to
3ee475f
Compare
Refactor stream management to support arbitrary span distributions. The new StreamSpan dataclass encapsulates stream metadata and operations, while partially_populate_device() now supports configurable span counts and skip patterns. This required to upgrade randstream to the version 0.6.0 which supports arbitrary position. The default cap is 2GiB. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/fix-xva-import-space-pslw
branch
from
May 12, 2026 13:23
3ee475f to
7a8a2d7
Compare
glehmann
force-pushed
the
gln/limit-vdi-write-cap-umro
branch
from
May 12, 2026 13:23
f2fef78 to
fdd3cbf
Compare
Lankou66
approved these changes
May 12, 2026
Millefeuille42
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor stream management to support arbitrary span distributions.
The new StreamSpan dataclass encapsulates stream metadata and operations,
while partially_populate_device() now supports configurable span counts
and skip patterns.
This required to upgrade randstream to the version 0.6.0 which supports
arbitrary position.
The default cap is 2GiB.
Signed-off-by: Gaëtan Lehmann gaetan.lehmann@vates.tech
This PR is part of a tree containing 19 PRs:
mastermaster