-
Notifications
You must be signed in to change notification settings - Fork 722
feat(autoware_pointcloud_preprocessor): add roi excluded downsample #10233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(autoware_pointcloud_preprocessor): add roi excluded downsample #10233
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
46b11ac
to
1982bc7
Compare
be3b755
to
0c63f77
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10233 +/- ##
==========================================
- Coverage 24.72% 24.69% -0.03%
==========================================
Files 1313 1313
Lines 102645 102739 +94
Branches 38985 39028 +43
==========================================
Hits 25374 25374
- Misses 74862 74955 +93
- Partials 2409 2410 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaancolak
Sorry for late reviewing.
Code itself looks okay to me. But do you really need this filter now?
I mean voxel grid downsample in far distance won't do much filtering, so I wonder if just adding roi cropping function in voxel downsampling filter will satisfy your case and that would be more versatile.
...pointcloud_preprocessor/downsample_filter/pickup_based_voxel_grid_downsample_filter_node.hpp
Outdated
Show resolved
Hide resolved
Thank you so much for your feedback. Laser points from a single lidar are mostly dense at a long distance, but this enhancement is functional when multiple lasers which comes different lidar fall on the same object at a long distance. As you said, making this an optional function makes sense to me. |
Signed-off-by: Kaan Çolak <[email protected]>
fadff49
to
7c683d9
Compare
@YoshiRi -san, I updated the code to enable and disable roi exclusion with a single parameter in the voxel grid downsample filter and kept changes minimum. Could you review it when you have a chance? |
Description
This filter provides selective downsampling that preserves detailed point data in critical regions while reducing overall point cloud density:
The main purpose is to detect long-range stationary vehicles on the road, such as those stopped at an intersection or traffic light. With the point cloud densifier node, points at a distance will be densified and downsampling will not be applied in this densified area thanks to the roi excluded voxel-based downsampling operation.
2025-03-05.15-12-08.mp4
Parent Issue:
Relevant issue: feat(autoware_pointcloud_preprocessor): add pointcloud_densifier package #10226
Private Links:
How was this PR tested?
Notes for reviewers
run ->
ros2 launch autoware_pointcloud_preprocessor roi_excluded_voxel_grid_downsample_filter.launch.xml
Interface changes
None.
Effects on system behavior
None.