Skip to content

feat(autoware_radar_objects_adapter): add publisher for tracks with uuid #10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Apr 25, 2025

Description

As per the title

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Apr 25, 2025
Copy link

github-actions bot commented Apr 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@knzo25 knzo25 requested review from YoshiRi and technolojin April 25, 2025 06:44
@technolojin technolojin self-assigned this Apr 30, 2025
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.

Project coverage is 25.04%. Comparing base (c6a70d2) to head (8dff9f0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...adar_objects_adapter/src/radar_objects_adapter.cpp 0.00% 110 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10556      +/-   ##
==========================================
+ Coverage   24.95%   25.04%   +0.08%     
==========================================
  Files        1351     1351              
  Lines      105130   105201      +71     
  Branches    39761    39771      +10     
==========================================
+ Hits        26240    26344     +104     
+ Misses      76397    76356      -41     
- Partials     2493     2501       +8     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 25.06% <ø> (+0.11%) ⬆️ Carriedforward from 73d5b96

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@technolojin technolojin force-pushed the feat/radar_to_tracks branch from cdf1599 to 874922b Compare May 2, 2025 03:47
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels May 2, 2025
@technolojin technolojin force-pushed the feat/radar_to_tracks branch from 874922b to 2870eb6 Compare May 2, 2025 03:49
@github-actions github-actions bot removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels May 2, 2025
@technolojin technolojin requested a review from YoshiRi May 2, 2025 04:09
@technolojin technolojin force-pushed the feat/radar_to_tracks branch 2 times, most recently from b0e7577 to d7507eb Compare May 7, 2025 03:54
@technolojin
Copy link
Contributor

tested with a driving record, and the tracked objects are confirmed.

Screenshot from 2025-05-07 12-55-48

Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin
Copy link
Contributor

technolojin commented May 7, 2025

need to update the code owner
#10504

@mitsudome-r @yukkysaito
Can you help us to merge the code owner udpate?

-> it has been merged.

knzo25 and others added 5 commits May 7, 2025 13:31
@technolojin technolojin force-pushed the feat/radar_to_tracks branch from d7507eb to 8dff9f0 Compare May 7, 2025 04:31
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit fb12d5d into autowarefoundation:main May 8, 2025
35 of 36 checks passed
@github-project-automation github-project-automation bot moved this from To Triage to Done in Software Working Group May 8, 2025
mkquda pushed a commit to tier4/autoware_universe that referenced this pull request Jun 16, 2025
…uid (autowarefoundation#10556)

* feat: added the option to publish tracks in addition to detections

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* chore: forgot to add the uuids

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat: added hashes to avoid conflicts between radars

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

* feat(radar_objects_adapter): update QoS settings for detections and tracks publishers

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: integrate common convert processes

refactor: simplify function signatures in radar_objects_adapter
Signed-off-by: Taekjin LEE <[email protected]>

* refactor: rename parameters for clarity in radar covariance functions

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: rename input parameter for clarity in objects_callback and related functions

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: Taekjin LEE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants