feat(autoware_radar_objects_adapter): add publisher for tracks with uuid #10556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
YoshiRi
requested changes
Apr 30, 2025
| pub_ = create_publisher<autoware_perception_msgs::msg::DetectedObjects>( | ||
| "~/output/objects", rclcpp::SensorDataQoS()); | ||
| detections_pub_ = create_publisher<autoware_perception_msgs::msg::DetectedObjects>( | ||
| "~/output/detections", rclcpp::SensorDataQoS()); |
There was a problem hiding this comment.
Many subscriber do receive DetectedObjects and TrackedObjects with Reliable policy. Would you mind quit sensor qos policy so that it will be easier to handle these information?
Suggested change
| "~/output/detections", rclcpp::SensorDataQoS()); | |
| "~/output/detections", 10); |
| "~/output/detections", rclcpp::SensorDataQoS()); | ||
|
|
||
| tracks_pub_ = create_publisher<autoware_perception_msgs::msg::TrackedObjects>( | ||
| "~/output/tracks", rclcpp::SensorDataQoS()); |
There was a problem hiding this comment.
same comment with above.
Suggested change
| "~/output/tracks", rclcpp::SensorDataQoS()); | |
| "~/output/tracks", 10); |
| detections_pub_->publish(std::move(output_msg_ptr)); | ||
| } | ||
|
|
||
| void RadarObjectsAdapter::parse_as_tracks( |
There was a problem hiding this comment.
[just a comment]
kinematics and class calculation can be shared with detection conversion. But I do not push it for now.
technolojin
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10556 +/- ##
==========================================
- Coverage 24.97% 24.96% -0.02%
==========================================
Files 1351 1351
Lines 105139 105197 +58
Branches 39766 39771 +5
==========================================
Hits 26262 26262
- Misses 76385 76443 +58
Partials 2492 2492
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
technolojin
force-pushed
the
feat/radar_to_tracks
branch
from
cdf1599 to
874922b
Compare
technolojin
requested review from
scepter914,
MasatoSaeki and
yukkysaito
as code owners
github-actions
bot
added
component:perception
technolojin
force-pushed
the
feat/radar_to_tracks
branch
from
874922b to
2870eb6
Compare
github-actions
bot
removed
component:perception
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…racks publishers Signed-off-by: Taekjin LEE <[email protected]>
refactor: simplify function signatures in radar_objects_adapter Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
technolojin
force-pushed
the
feat/radar_to_tracks
branch
from
fe69c73 to
b0e7577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the title
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.