ci: use underlay workspace for build-and-test workflows#12536
ci: use underlay workspace for build-and-test workflows#12536mitsudome-r wants to merge 3 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
e712d58 to
b760ebf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12536 +/- ##
===========================================
- Coverage 18.64% 13.60% -5.05%
===========================================
Files 1917 184 -1733
Lines 131368 12169 -119199
Branches 44506 4484 -40022
===========================================
- Hits 24494 1655 -22839
+ Misses 86757 9260 -77497
+ Partials 20117 1254 -18863
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5a4c971 to
6a1aaed
Compare
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
6c42e33 to
37c7c8e
Compare
|
autoware_core's latest pinned version (from autoware.repos) is in the underlay workspaces due to way our docker build and push workflow works, it imports autoware.repos only. autoware_universe/build_depends_nightly.repos Lines 9 to 12 in 2ad15b1 But this repo depends on main branch of Adding it as an underlay workspace would cause conflicts.
|
|
Of course, we can go with underlay_ws option too. But to do that, we should remove all mentions of autoware_universe/build_depends_stable.repos Lines 2 to 31 in 2ad15b1 And also remove the concept of https://github.com/autowarefoundation/autoware_universe/blob/main/build_depends_nightly.repos altogether (from this repository). It'll work. It will reduce the flexibility and will require either having to make non-breaking changes as we develop. But it will work. Thinking more on this: If we remove https://github.com/autowarefoundation/autoware_universe/blob/main/build_depends_nightly.repos then it also means that So I'm conflicted about this, needs further discussion. Only way I can see this working is that if we leave only autoware_universe as main branch in autoware-nightly and remove all else. This is the only way we can promise |
|
@xmfcx I also mentioned the approach in the "How to fix" section in the linked issue. At least, autoware_core main branch is always tested with I will create another PR for now to just update the repos files instead. I will change this PR to draft and maybe bring it as a discussion topic in the next Software WG call. |
Description
Resolves issue #12535
Related links
Parent Issue:
How was this PR tested?
I added a test commit temporarily to trigger the build of autoware_system_designs.
Without underlay workspace it fails:

https://github.com/autowarefoundation/autoware_universe/actions/runs/25227669086/job/73975189683?pr=12536
With underlay workspace sourced:

https://github.com/autowarefoundation/autoware_universe/actions/runs/25226017986/job/73969661204?pr=12536
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.