Introduce vFloat and float types in ParameterSets

[felicepantaleo]

Description

This pull request introduces vFloat and float types in the ParameterSets of the CMSSW framework. The changes aim to improve the precision and performance of floating-point parameter handling in configuration sets.

Changes

1. Added vFloat and float type definitions.
2. Updated relevant configuration files to utilize the new types.
3. Ensured compatibility with existing functionality and modules.

This will allow the developers of C++ modules to directly use std::vector<float> configuration parameters avoiding manually converting each of them from std::vector<double>, if double precision is not needed.

Testing

• Ran all existing unit tests.
• Added new tests to cover the vFloat and float types.
• Tested with workflow 24900.0.
• Verified no regressions in performance or functionality.

Future Work

If the tests run smoothly, an existing reconstruction module will be migrated from double to float within this pull request.

@smuzaffar @makortel @Dr15Jones @fwyzard @rovere @VinInn FYI

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45216/40573

• This PR adds an extra 132KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45216/40573/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45216/40573/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45216/40574

• This PR adds an extra 124KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276

[cmsbuild]

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

• FWCore/ParameterSet (core)
• FWCore/PythonParameterSet (core)

@cmsbuild, @makortel, @Dr15Jones, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

test parameters:

• workflow = 25288.203,25488.203

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ee9da/39871/summary.html
COMMIT: 4e3d218
CMSSW: CMSSW_14_1_X_2024-06-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45216/39871/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 25288.203, 25488.203

[felicepantaleo]

test parameters:

[felicepantaleo]

@cmsbuild please test

[smuzaffar]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45216/43099

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.