Skip to content

Conversation

@cngonzalez
Copy link
Member

Description

We keep getting test failures on this test in Webkit because "Sign in with Google" changed to "Continue with Google". Let's stay clear of any further changes by being a bit less strict about what we're checking for.

What to review

Will this work?

Testing

Hopefully the tests pass.

Fun gif

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sdk-docs Ready Ready Preview, Comment Feb 5, 2026 3:00pm
sdk-kitchensink-react Ready Ready Preview, Comment Feb 5, 2026 3:00pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 95.28% (🎯 95%) 7773 / 8158
🟢 Statements 95.28% (🎯 95%) 7773 / 8158
🟢 Functions 96.24% (🎯 95%) 384 / 399
🟢 Branches 92.95% (🎯 90%) 2308 / 2483
File CoverageNo changed files found.
Generated in workflow #2887 for commit caf89f8 by the Vitest Coverage Report Action

@cngonzalez cngonzalez marked this pull request as ready for review February 5, 2026 14:58
@cngonzalez cngonzalez requested a review from a team as a code owner February 5, 2026 14:58
@cngonzalez cngonzalez requested a review from mttdnt February 5, 2026 14:58
@cngonzalez cngonzalez merged commit bb1eac4 into main Feb 5, 2026
21 checks passed
@cngonzalez cngonzalez deleted the make-signin-tests-more-lenient branch February 5, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants