-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(presence): convert presence to use source #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 02-05-refactor_localize_not_using_resource_on_client_to_the_client_store
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6db321f to
dbc5509
Compare
5e742fe to
c6a1b4c
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
dbc5509 to
8bbde5b
Compare
8bbde5b to
6726b25
Compare
c6a1b4c to
7474e0d
Compare
6726b25 to
6c8d1bf
Compare
laurenashpole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!

Description
Presence as it's implemented in the SDK right now doesn't seem to work for Canvas or Media Library (we get a Websocket error) but we still need to move it to source for architectural reasons. This PR does that.
What to review
presenceStore.tsimplementation which now validates source typesusePresencehook that accepts source options and validates themTesting
Added comprehensive tests for:
FIXES SDK-760