-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: localize not using resource on client to the client store #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cngonzalez
wants to merge
1
commit into
02-05-feat_releases_update_releases_store_to_use_sources
Choose a base branch
from
02-05-refactor_localize_not_using_resource_on_client_to_the_client_store
base: 02-05-feat_releases_update_releases_store_to_use_sources
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Feb 6, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 6, 2026
5e742fe to
c6a1b4c
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
244d2ae to
1a852cf
Compare
c6a1b4c to
7474e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
While going through this source refactor, there was a lot of ad-hoc checking for a dataset source, since some of the global API endpoints for datasets are still on vX only.
That's hard for maintainers, so it's now centralized to the client store.
What to review
clientStore.tswhere we now handle dataset sources by extracting projectId/dataset rather than creating a resourceTesting
The existing test suite has been updated to reflect the new behavior, with one test being skipped until the full migration to using source for project and dataset is complete.
Fun GIF