Skip to content

Conversation

@cngonzalez
Copy link
Member

@cngonzalez cngonzalez commented Feb 6, 2026

Description

While going through this source refactor, there was a lot of ad-hoc checking for a dataset source, since some of the global API endpoints for datasets are still on vX only.

That's hard for maintainers, so it's now centralized to the client store.

What to review

  • Review the changes in clientStore.ts where we now handle dataset sources by extracting projectId/dataset rather than creating a resource
  • Check the removal of conditional guards in various files that were previously preventing dataset sources from being passed to client operations
  • Verify that the skipped test is appropriately marked for future implementation

Testing

The existing test suite has been updated to reflect the new behavior, with one test being skipped until the full migration to using source for project and dataset is complete.

Fun GIF

@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sdk-docs Ready Ready Preview, Comment Feb 6, 2026 4:49pm
sdk-kitchensink-react Ready Ready Preview, Comment Feb 6, 2026 4:49pm

Request Review

Copy link
Member Author

cngonzalez commented Feb 6, 2026

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 95.38% (🎯 95%) 7819 / 8197
🟢 Statements 95.38% (🎯 95%) 7819 / 8197
🟢 Functions 95.96% (🎯 95%) 381 / 397
🟢 Branches 92.96% (🎯 90%) 2301 / 2475
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/client/clientStore.ts 98.51% 92.15% 100% 98.51% 237-238
packages/core/src/document/documentStore.ts 92.58% 88.5% 77.77% 92.58% 207-214, 226-229, 281-284, 363, 460-461, 474-475, 505-506
packages/core/src/document/sharedListener.ts 100% 100% 100% 100%
packages/core/src/preview/previewProjectionUtils.ts 100% 95% 100% 100%
packages/core/src/projection/subscribeToStateAndFetchBatches.ts 97.86% 83.78% 75% 97.86% 132, 171, 232-234
packages/core/src/query/queryStore.ts 96.61% 95.52% 100% 96.61% 183-185, 239-244
packages/core/src/releases/releasesStore.ts 100% 100% 100% 100%
Generated in workflow #2926 for commit 7474e0d by the Vitest Coverage Report Action

@cngonzalez cngonzalez marked this pull request as ready for review February 6, 2026 15:13
@cngonzalez cngonzalez requested a review from a team as a code owner February 6, 2026 15:13
@cngonzalez cngonzalez requested review from somerandomdude and removed request for a team February 6, 2026 15:13
@cngonzalez cngonzalez force-pushed the 02-05-feat_releases_update_releases_store_to_use_sources branch from 244d2ae to 1a852cf Compare February 6, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant