Skip to content

starknet_os: os resources test - add keccak#14139

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_3_more_syscallsfrom
05-23-starknet_os_os_resources_test_-_add_keccak
Open

starknet_os: os resources test - add keccak#14139
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_3_more_syscallsfrom
05-23-starknet_os_os_resources_test_-_add_keccak

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes fee/OS resource accounting and allowed virtual OS program hashes, which affect proving and gas metering consistency across the network stack.

Overview
Extends the OS resources regression harness to measure Keccak (empty input for base cost, 17×u64 for one round) and records Keccak / KeccakRound in versioned constants, with special handling because round cost is stored under KeccakRound rather than a calldata factor on Keccak.

Bumps OS and virtual OS program hashes (program_hash.json, Cairo ALLOWED_VIRTUAL_OS_PROGRAM_HASHES_2, and 0.14.4 allowed hashes) and raises KECCAK_ROUND_COST_GAS_COST (171707 → 175207) and KeccakRound n_steps (281 → 316) to match the rebuilt OS.

Reviewed by Cursor Bugbot for commit f287752. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_keccak branch 2 times, most recently from d6c4ad3 to 1739107 Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 01423bf to 5d943b5 Compare May 25, 2026 09:48
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_keccak branch from 1739107 to 25d1fa1 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 5d943b5 to 1510ab1 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 1510ab1 to edfe6a8 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_keccak branch from 25d1fa1 to 61397d7 Compare May 29, 2026 14:04
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 61397d7. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from edfe6a8 to 682a9bb Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_keccak branch from 61397d7 to 4417771 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_keccak branch from 4417771 to f287752 Compare June 1, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants