starknet_os: os resources test - add meta tx#14135
Conversation
PR SummaryMedium Risk Overview The OS resources test contract now invokes The deployable measurement account’s
Reviewed by Cursor Bugbot for commit e970e02. Bugbot is set up for automated code reviews on this repo. Configure here. |
08dbf97 to
f7fd3a3
Compare
311e125 to
a775a63
Compare
f7fd3a3 to
3ca8f12
Compare
a775a63 to
268457e
Compare
dafb7a8 to
ce6eb29
Compare
268457e to
8b293fb
Compare
ce6eb29 to
f48908d
Compare
8b293fb to
bd9c3be
Compare
f48908d to
f30d4c1
Compare
bd9c3be to
9711ff8
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 69 at r1 (raw file):
calldata: array![0, 0, 0, 0].span(), signature: array![].span(), )
Call the const contract instead, so you could have a base cost without arguments (same comment as the deploy syscall)
Code quote:
// meta_tx_v0 syscall - base.
meta_tx_v0_syscall(
address: self_address,
entry_point_selector: EXECUTE_FUNCTION_SELECTOR,
// class hash, address, deployable class hash, extra args len.
calldata: array![0, 0, 0, 0].span(),
signature: array![].span(),
)f30d4c1 to
ed74ad5
Compare
9711ff8 to
cfcc21d
Compare
cfcc21d to
cca3d02
Compare
ed74ad5 to
7c9637b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7c9637b. Configure here.
cca3d02 to
dc656bd
Compare
7c9637b to
616bec9
Compare
616bec9 to
e970e02
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 9 files and all commit messages, and made 4 comments.
Reviewable status: 9 of 10 files reviewed, 5 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 368 at r2 (raw file):
"builtin_instance_counter": { "range_check_builtin": 20, "pedersen_builtin": 10
The number of builtins has changed.
Code quote:
"pedersen_builtin": 10crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 74 at r2 (raw file):
// this reason we deploy from zero, and choose a specific salt. // base (no calldata): deploy_syscall(stable_class_hash, 1, array![0].span(), true).unwrap_syscall();
Why?
Code quote:
1,crates/starknet_os_flow_tests/src/os_resources_test.rs line 213 at r2 (raw file):
// TODO(Dori): Consider supporting memory-hole counting in the OsLogger. Until then, we // cannot subtract inner calls with positive memory-hole counts from the OsLogger // resources.
You can count the memory holes if you don't put all the syscalls in a single tx.
Code quote:
// TODO(Dori): Consider supporting memory-hole counting in the OsLogger. Until then, we
// cannot subtract inner calls with positive memory-hole counts from the OsLogger
// resources.crates/starknet_os_flow_tests/src/os_resources_test.rs line 215 at r2 (raw file):
// resources. let mut inner_resources = inner_calls_iter.next().unwrap().resources.vm_resources; inner_resources.n_memory_holes = 0;
The n_memory_holes is zero for all the resources in the versioned constants.
Code quote:
inner_resources.n_memory_holes = 0

No description provided.