Skip to content

starknet_os: os resources test - add send_message_to_l1#14143

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_replace_classfrom
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1
Open

starknet_os: os resources test - add send_message_to_l1#14143
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_replace_classfrom
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Touches fee/gas constants and OS program hashes used for proving and client compatibility, though changes are driven by regression measurement rather than new protocol logic.

Overview
Extends the OS resources regression harness so send_message_to_l1 is exercised and its OS overhead is captured like other measurable syscalls.

The Cairo1 OsResourcesTestContract now calls send_message_to_l1_syscall with an empty payload; the flow test drops SendMessageToL1 from the unmeasurable list, asserts the resulting L2→L1 message (to address 100), and refreshes 0.14.4 versioned constants: SendMessageToL1 n_steps 144 → 124 and matching SEND_MESSAGE_TO_L1_GAS_COST 14470 → 12470 in OS Cairo constants. program_hash.json, allowed virtual OS program hash slot 2, and the 0.14.3→0.14.4 diff regression snippet are updated for the rebuilt OS artifacts.

Reviewed by Cursor Bugbot for commit c91e910. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 9534bec to ed548b5 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 39edd2e to b4dc505 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from ed548b5 to 8be4f98 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from b4dc505 to 6d69bf0 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 6d69bf0 to a359fa6 Compare May 29, 2026 14:04
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a359fa6. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from a359fa6 to dda5432 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from dda5432 to c91e910 Compare June 1, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants