Skip to content

starknet_os: os resources test - add secp syscalls#14144

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1from
05-23-starknet_os_os_resources_test_-_add_secp_syscalls
Open

starknet_os: os resources test - add secp syscalls#14144
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1from
05-23-starknet_os_os_resources_test_-_add_secp_syscalls

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Touches protocol-facing OS gas constants, allowed virtual OS hashes, and program hashes used for proving compatibility; changes are driven by remeasured syscall costs but affect fee and validation expectations.

Overview
Adds secp256k1 and secp256r1 syscall coverage to the OS resources measurement harness so their VM step costs are captured by the regression test instead of being skipped.

The Cairo OsResourcesTestContract now exercises all ten secp syscalls in __execute__, with fixed curve constants. os_resources_test drops those selectors from UNMEASURABLE_SYSCALLS and allows Secp256k1New / Secp256r1New to appear twice in traces (second visit ignored). Measured n_steps and matching OS gas constants for secp syscalls are lowered slightly; blockifier_versioned_constants_0_14.4.json, constants.cairo, program_hash.json, and the 0.14.3→0.14.4 diff file are updated accordingly, including a new allowed virtual OS program hash and refreshed OS / virtual_os hashes.

Reviewed by Cursor Bugbot for commit 485162f. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 39edd2e to b4dc505 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch 2 times, most recently from ac5afa2 to 82b5e4f Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from b4dc505 to 6d69bf0 Compare May 28, 2026 16:18
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82b5e4f. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 6d69bf0 to a359fa6 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 82b5e4f to 41c9f3d Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from a359fa6 to dda5432 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 41c9f3d to 985e731 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from dda5432 to c91e910 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 985e731 to 485162f Compare June 1, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants