Decompose sprites #1771
Open
Decompose sprites #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name = Compass::SpriteImporter.sprite_name(relative_uri) | ||
| sprites = Compass::SpriteImporter.new | ||
| name = Compass::Sprites::Importer.sprite_name(relative_uri) | ||
| sprites = Compass::Sprites::Importer.new |
There was a problem hiding this comment.
Useless assignment to variable - sprites.
There was a problem hiding this comment.
no idea looks like it was caught in the global rename macro i ran
This was referenced Aug 18, 2014
Closed
|
Thank you for your work Scott. O_O |
scottdavis
force-pushed
the
decompose_sprites
branch
from
9aa5706 to
c2553c6
Compare
|
ping @chriseppstein this is massive so review it well all tests are passing |
…lt allowing jpg, gif, etc
scottdavis
force-pushed
the
decompose_sprites
branch
from
540395f to
ef9e3e5
Compare
| ).each do |lib| | ||
| require "compass/#{lib}" | ||
| end | ||
| #tem |
There was a problem hiding this comment.
Not sure what this comment is for. Delete it?
|
also i botched up travis some how https://travis-ci.org/Compass/compass/jobs/36176909 |
* Remove Imported injection from compass core * Move Sprite stylesheets into sprite gem * Updated tests
scottdavis
force-pushed
the
decompose_sprites
branch
from
3ddba37 to
eff65e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Moves sprites to a compass plugin.