Change the order of the process state listen invocation#1984
Merged
bidetofevil merged 1 commit intomainfrom Mar 5, 2025
Merged
Change the order of the process state listen invocation#1984bidetofevil merged 1 commit intomainfrom
bidetofevil merged 1 commit intomainfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1984 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 482 482
Lines 11233 11233
Branches 1686 1686
=======================================
Hits 9585 9585
Misses 906 906
Partials 742 742
|
Contributor
Author
Merge activity
|
bidetofevil
force-pushed
the
hho/process-state-invocation
branch
2 times, most recently
from
14579a7 to
7488cca
Compare
bidetofevil
force-pushed
the
hho/process-state-invocation
branch
from
7488cca to
a5c8271
Compare
This was referenced Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Invoke the onBackground callback for the
SessionOrchestratorlast so that every other service has a chance to "do the wrap up before going into the background" thing.Currently, this only affects the ANR service, which means it'll stop monitoring ANRs just before the session payload is taken. A side effect of this is our session payload creation time won't be counted in an on-going ANR, which seems to be correct to me as the app will soon not be on screen, so extending the blockage interval doesn't seem like it adds much value.