Skip to content

Consolidate storage service fakes and usage#2002

Merged
bidetofevil merged 1 commit intomainfrom
hho/storage-faking
Mar 8, 2025
Merged

Consolidate storage service fakes and usage#2002
bidetofevil merged 1 commit intomainfrom
hho/storage-faking

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 6, 2025

Goal

Consolidate the fake PayloadStorageService and set them up within the setup object if required. I also made it so that each instance of the setup object creates a new processIdentifier, which avoids any erroneous tests that checks for a hardcoded ID. If you need a stable one, it can always be overridden.

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Mar 6, 2025

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (ba0c157) to head (10946bc).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
+ Coverage   85.37%   85.39%   +0.01%     
==========================================
  Files         482      482              
  Lines       11234    11234              
  Branches     1686     1686              
==========================================
+ Hits         9591     9593       +2     
  Misses        902      902              
+ Partials      741      739       -2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidetofevil bidetofevil marked this pull request as ready for review March 6, 2025 23:53
@bidetofevil bidetofevil requested a review from a team as a code owner March 6, 2025 23:53
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from 4b472de to 40b2f28 Compare March 6, 2025 23:54
@bidetofevil bidetofevil requested review from fractalwrench and removed request for a team March 6, 2025 23:54
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from 40b2f28 to e95d01c Compare March 7, 2025 00:12
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from e95d01c to f83ecfb Compare March 7, 2025 01:22
Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from f83ecfb to b262c58 Compare March 7, 2025 14:48
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from b262c58 to 00d6ff9 Compare March 7, 2025 15:01
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch 2 times, most recently from 9696dd7 to b60ed2d Compare March 7, 2025 15:19
@bidetofevil bidetofevil changed the base branch from hho/further-test-rule-simp to graphite-base/2002 March 7, 2025 17:26
@bidetofevil bidetofevil changed the base branch from graphite-base/2002 to main March 7, 2025 17:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil changed the base branch from main to graphite-base/2002 March 7, 2025 22:10
@bidetofevil bidetofevil changed the base branch from graphite-base/2002 to hho/ignore-startup-error March 7, 2025 22:10
@bidetofevil bidetofevil changed the base branch from hho/ignore-startup-error to graphite-base/2002 March 8, 2025 00:18
@bidetofevil bidetofevil changed the base branch from graphite-base/2002 to hho/ignore-startup-error March 8, 2025 00:57
@bidetofevil bidetofevil changed the base branch from hho/ignore-startup-error to graphite-base/2002 March 8, 2025 01:11
@bidetofevil bidetofevil changed the base branch from graphite-base/2002 to main March 8, 2025 01:12
@bidetofevil bidetofevil merged commit c58f925 into main Mar 8, 2025
11 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

  • Mar 8, 1:17 AM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil deleted the hho/storage-faking branch March 8, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants