Consolidate storage service fakes and usage#2002
Merged
bidetofevil merged 1 commit intomainfrom Mar 8, 2025
Merged
Conversation
This was referenced Mar 6, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
307b93a to
4b472de
Compare
990a990 to
1a71f67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
+ Coverage 85.37% 85.39% +0.01%
==========================================
Files 482 482
Lines 11234 11234
Branches 1686 1686
==========================================
+ Hits 9591 9593 +2
Misses 902 902
+ Partials 741 739 -2 🚀 New features to boost your workflow:
|
1a71f67 to
e475950
Compare
4b472de to
40b2f28
Compare
40b2f28 to
e95d01c
Compare
e475950 to
babffa4
Compare
babffa4 to
7dc9f79
Compare
e95d01c to
f83ecfb
Compare
f83ecfb to
b262c58
Compare
7dc9f79 to
01f616a
Compare
b262c58 to
00d6ff9
Compare
01f616a to
0ff007b
Compare
9696dd7 to
b60ed2d
Compare
0ff007b to
c7ca82e
Compare
c7ca82e to
73fe64d
Compare
73fe64d to
d26d34b
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
d26d34b to
ce5245a
Compare
ce5245a to
7487333
Compare
7487333 to
aaa1256
Compare
d45f0a8 to
ba0c157
Compare
aaa1256 to
ae3431b
Compare
ae3431b to
1b12c23
Compare
1b12c23 to
5d13fb2
Compare
5d13fb2 to
10946bc
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Consolidate the fake PayloadStorageService and set them up within the setup object if required. I also made it so that each instance of the setup object creates a new
processIdentifier, which avoids any erroneous tests that checks for a hardcoded ID. If you need a stable one, it can always be overridden.