Further simplify the integration test rule#1999
Merged
bidetofevil merged 1 commit intomainfrom Mar 7, 2025
Merged
Conversation
This was referenced Mar 6, 2025
Contributor
Author
This was referenced Mar 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 482 482
Lines 11234 11234
Branches 1686 1686
=======================================
Hits 9593 9593
Misses 901 901
Partials 740 740 🚀 New features to boost your workflow:
|
This was referenced Mar 6, 2025
b632020 to
e78af3c
Compare
e78af3c to
804e59a
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
804e59a to
fac324a
Compare
fac324a to
9ee7061
Compare
Contributor
Author
9ee7061 to
2d489f8
Compare
2d489f8 to
35d9a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Miscellaneous changes to reduce the number of things you can override in the integration test setup. Most of what's being overridden was just so the tests can read the data, so either we provide the fake right in the setup object, or we expose the real component so it can be read.
These components were being faked universally in the integration tests anyway, so this doesn't make the tests less comprehensive.
Note: more changes are coming. I just had to break them up as I wanted to do some more targeted changes later on so they can be more easily reviewed.