Skip to content

Further simplify the integration test rule#1999

Merged
bidetofevil merged 1 commit intomainfrom
hho/harness-slimming
Mar 7, 2025
Merged

Further simplify the integration test rule#1999
bidetofevil merged 1 commit intomainfrom
hho/harness-slimming

Conversation

@bidetofevil
Copy link
Contributor

@bidetofevil bidetofevil commented Mar 6, 2025

Goal

Miscellaneous changes to reduce the number of things you can override in the integration test setup. Most of what's being overridden was just so the tests can read the data, so either we provide the fake right in the setup object, or we expose the real component so it can be read.

These components were being faked universally in the integration tests anyway, so this doesn't make the tests less comprehensive.

Note: more changes are coming. I just had to break them up as I wanted to do some more targeted changes later on so they can be more easily reviewed.

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (bfc95ce) to head (35d9a56).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         482      482           
  Lines       11234    11234           
  Branches     1686     1686           
=======================================
  Hits         9593     9593           
  Misses        901      901           
  Partials      740      740           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidetofevil bidetofevil changed the base branch from hho/reduce-test-setup-override to graphite-base/1999 March 6, 2025 23:19
@bidetofevil bidetofevil force-pushed the hho/harness-slimming branch from b632020 to e78af3c Compare March 6, 2025 23:19
@bidetofevil bidetofevil changed the base branch from graphite-base/1999 to main March 6, 2025 23:19
@bidetofevil bidetofevil force-pushed the hho/harness-slimming branch from e78af3c to 804e59a Compare March 6, 2025 23:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil marked this pull request as ready for review March 6, 2025 23:24
@bidetofevil bidetofevil requested a review from a team as a code owner March 6, 2025 23:24
@bidetofevil bidetofevil force-pushed the hho/harness-slimming branch from 804e59a to fac324a Compare March 7, 2025 00:12
@bidetofevil bidetofevil force-pushed the hho/harness-slimming branch from fac324a to 9ee7061 Compare March 7, 2025 01:22
Copy link
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

bidetofevil commented Mar 7, 2025

Merge activity

  • Mar 7, 9:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 7, 9:47 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 7, 10:00 AM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil force-pushed the hho/harness-slimming branch from 9ee7061 to 2d489f8 Compare March 7, 2025 14:47
@bidetofevil bidetofevil force-pushed the hho/harness-slimming branch from 2d489f8 to 35d9a56 Compare March 7, 2025 14:48
@bidetofevil bidetofevil merged commit d9f3e22 into main Mar 7, 2025
11 checks passed
@bidetofevil bidetofevil deleted the hho/harness-slimming branch March 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants