Reduce the usage of fake workers in integration tests#2000
Merged
bidetofevil merged 1 commit intomainfrom Mar 7, 2025
Merged
Conversation
This was referenced Mar 6, 2025
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
+ Coverage 85.39% 85.41% +0.01%
==========================================
Files 482 482
Lines 11234 11234
Branches 1686 1686
==========================================
+ Hits 9593 9595 +2
Misses 901 901
+ Partials 740 738 -2 🚀 New features to boost your workflow:
|
This was referenced Mar 6, 2025
bidetofevil
force-pushed
the
hho/harness-slimming
branch
2 times, most recently
from
e78af3c to
804e59a
Compare
bidetofevil
force-pushed
the
hho/reduce-fake-workers
branch
from
22b3ab4 to
1dd2058
Compare
bidetofevil
commented
Mar 6, 2025
| testCaseAction = { | ||
| embrace.logWarning("test message") | ||
| flushLogs() | ||
| clock.tick(2000L) |
Contributor
Author
There was a problem hiding this comment.
Need to move time ahead so the batching logic kicks in
bidetofevil
commented
Mar 6, 2025
| allowPeriodicCacheExecution() | ||
| assertEquals(1, cacheStorageService.storedPayloads.size) | ||
| snapshot = loadSnapshot(cacheStorageService) | ||
| val dataSupplier = { cacheStorageService.storedPayloads } |
Contributor
Author
There was a problem hiding this comment.
Note: this is further refactored in a PR later on
bidetofevil
force-pushed
the
hho/reduce-fake-workers
branch
from
1dd2058 to
e1134e0
Compare
bidetofevil
force-pushed
the
hho/harness-slimming
branch
from
804e59a to
fac324a
Compare
bidetofevil
force-pushed
the
hho/reduce-fake-workers
branch
from
e1134e0 to
bace552
Compare
bidetofevil
force-pushed
the
hho/harness-slimming
branch
from
fac324a to
9ee7061
Compare
bidetofevil
force-pushed
the
hho/reduce-fake-workers
branch
from
bace552 to
240adbb
Compare
bidetofevil
changed the base branch from
hho/harness-slimming
to
graphite-base/2000
bidetofevil
force-pushed
the
graphite-base/2000
branch
from
9ee7061 to
35d9a56
Compare
bidetofevil
force-pushed
the
hho/reduce-fake-workers
branch
2 times, most recently
from
5a094f6 to
1244467
Compare
bidetofevil
force-pushed
the
hho/reduce-fake-workers
branch
from
1244467 to
c8284b3
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Most workflows don't require faking workers anymore since we have a wait-for-payload mechanism in the integration tests now, which is more representative of the actual workflow.
The one remaining worker to fake is for ANR testing. Not sure if we can do without it but leaving it in for now.